Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create CachedBundleContentBanner Component #3632

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR creates the banner component that will be used in upcoming PRs, adding it to the Commit, and Pull pages.

Ticket: codecov/engineering-team#3153

Notable Changes

  • Create new CachedBundleContentBanner component
  • Add in tests

Screenshots

Screenshot 2025-01-06 at 10 34 41

@nicholas-codecov nicholas-codecov changed the title feat: Create bundle cache banner feat: Create CachedBundleContentBanner Component Jan 6, 2025
@codecov-staging
Copy link

Bundle Report

Bundle size has no change ✅

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3632   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         810      811    +1     
  Lines       14564    14566    +2     
  Branches     4148     4141    -7     
=======================================
+ Hits        14416    14418    +2     
  Misses        141      141           
  Partials        7        7           
Files with missing lines Coverage Δ
...dBundleContentBanner/CachedBundleContentBanner.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.37% <100.00%> (+<0.01%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9807408...a15b2bb. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (9807408) to head (a15b2bb).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3632   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         810      811    +1     
  Lines       14564    14566    +2     
  Branches     4148     4148           
=======================================
+ Hits        14416    14418    +2     
  Misses        141      141           
  Partials        7        7           
Files with missing lines Coverage Δ
...dBundleContentBanner/CachedBundleContentBanner.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.37% <100.00%> (+<0.01%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9807408...a15b2bb. Read the comment docs.

Copy link

codecov-public-qa bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (9807408) to head (a15b2bb).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3632   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         810      811    +1     
  Lines       14564    14566    +2     
  Branches     4141     4141           
=======================================
+ Hits        14416    14418    +2     
  Misses        141      141           
  Partials        7        7           
Files with missing lines Coverage Δ
...dBundleContentBanner/CachedBundleContentBanner.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.37% <100.00%> (+<0.01%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9807408...a15b2bb. Read the comment docs.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (9807408) to head (a15b2bb).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3632   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         810      811    +1     
  Lines       14564    14566    +2     
  Branches     4141     4141           
=======================================
+ Hits        14416    14418    +2     
  Misses        141      141           
  Partials        7        7           
Files with missing lines Coverage Δ
...dBundleContentBanner/CachedBundleContentBanner.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.37% <100.00%> (+<0.01%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9807408...a15b2bb. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
a15b2bb Mon, 06 Jan 2025 14:45:16 GMT Cloud Enterprise

Copy link

codecov bot commented Jan 6, 2025

Bundle Report

Bundle size has no change ✅

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit f7044f2 Jan 6, 2025
62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-3153-create-bundle-cache-banner branch January 6, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants