Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fetch isCached Field in PullPageDataQueryOpts #3622

Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR updates the query and validation schema for PullPageDataQueryOpts to include the isCached field for some upcoming work to inform users when a given pull request has data that has been cached from a previous commit included in it.

Tickets: codecov/engineering-team#3152

Notable Changes

  • Update query string and validation schema for PullPageDataQueryOpts
  • Add in new field in MSW tests

@nicholas-codecov nicholas-codecov changed the title feat: Fetch isCached field in PullPageDataQueryOpts feat: Fetch isCached Field in PullPageDataQueryOpts Jan 2, 2025
@codecov-staging
Copy link

codecov-staging bot commented Jan 2, 2025

Bundle Report

Changes will increase total bundle size by 2.23kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 6.06MB 1.13kB (0.02%) ⬆️
gazebo-staging-system 6.0MB 1.09kB (0.02%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (ecdafdb) to head (2b112ad).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3622      +/-   ##
==========================================
- Coverage   98.99%   98.98%   -0.01%     
==========================================
  Files         810      810              
  Lines       14556    14564       +8     
  Branches     4147     4148       +1     
==========================================
+ Hits        14409    14416       +7     
- Misses        140      141       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
.../PullRequestPage/queries/PullPageDataQueryOpts.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <100.00%> (+<0.01%) ⬆️
Services 99.33% <ø> (-0.04%) ⬇️
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecdafdb...2b112ad. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3622      +/-   ##
==========================================
- Coverage   98.99%   98.98%   -0.01%     
==========================================
  Files         810      810              
  Lines       14556    14564       +8     
  Branches     4147     4141       -6     
==========================================
+ Hits        14409    14416       +7     
- Misses        140      141       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
.../PullRequestPage/queries/PullPageDataQueryOpts.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <100.00%> (+<0.01%) ⬆️
Services 99.33% <ø> (-0.04%) ⬇️
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecdafdb...2b112ad. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.99%. Comparing base (ecdafdb) to head (307a1a9).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3622   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files         810      810           
  Lines       14556    14557    +1     
  Branches     4140     4140           
=======================================
+ Hits        14409    14410    +1     
  Misses        140      140           
  Partials        7        7           
Files with missing lines Coverage Δ
.../PullRequestPage/queries/PullPageDataQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <100.00%> (+<0.01%) ⬆️
Services 99.36% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecdafdb...307a1a9. Read the comment docs.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (ecdafdb) to head (2b112ad).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3622      +/-   ##
==========================================
- Coverage   98.99%   98.98%   -0.01%     
==========================================
  Files         810      810              
  Lines       14556    14564       +8     
  Branches     4140     4141       +1     
==========================================
+ Hits        14409    14416       +7     
- Misses        140      141       +1     
  Partials        7        7              
Files with missing lines Coverage Δ
.../PullRequestPage/queries/PullPageDataQueryOpts.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.72% <100.00%> (+<0.01%) ⬆️
Services 99.33% <ø> (-0.04%) ⬇️
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecdafdb...2b112ad. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jan 2, 2025

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
307a1a9 Thu, 02 Jan 2025 19:36:18 GMT Expired Expired
2b112ad Mon, 06 Jan 2025 11:59:30 GMT Cloud Enterprise

Copy link

codecov bot commented Jan 2, 2025

Bundle Report

Changes will increase total bundle size by 2.23kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.0MB 1.09kB (0.02%) ⬆️
gazebo-production-system-esm 6.06MB 1.13kB (0.02%) ⬆️

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit d88bff4 Jan 6, 2025
58 of 62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-3152-feat-fetch-isCached-field-in-pull-page-data branch January 6, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants