Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement RadioTileGroup component #2826

Merged
merged 12 commits into from May 3, 2024
Merged

feat: Implement RadioTileGroup component #2826

merged 12 commits into from May 3, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov commented May 1, 2024 •
edited

Description

Adds a new RadioTileGroup component to be used in repo and bundle onboarding. Description added preemptively to work with Failed test onboarding designs, which is coming soon.

Uses radixui react radio group and react label as base for accessibility.

Repo and bundle onboarding designs
Failed test onboarding designs

Screenshots

Storybook:

Screenshot 2024-05-01 at 16 23 05

@codecov-qa
Copy link

codecov-qa bot commented May 1, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (4ce2a59) to head (63fda55).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2826   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         869      870    +1     
  Lines       12729    12758   +29     
  Branches     3418     3423    +5     
=======================================
+ Hits        12535    12564   +29     
  Misses        190      190           
  Partials        4        4
Files Coverage Δ
src/ui/Card/Card.tsx 100.00% <100.00%> (ø)
src/ui/RadioTileGroup/RadioTileGroup.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.88% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.27% <ø> (ø)
Services 99.53% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.53% <100.00%> (+0.13%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce2a59...63fda55. Read the comment docs.

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review May 1, 2024 20:25
@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented May 1, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (4ce2a59) to head (63fda55).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2826   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         869      870    +1     
  Lines       12729    12758   +29     
  Branches     3423     3364   -59     
=======================================
+ Hits        12535    12564   +29     
  Misses        190      190           
  Partials        4        4
Files Coverage Δ
src/ui/Card/Card.tsx 100.00% <100.00%> (ø)
src/ui/RadioTileGroup/RadioTileGroup.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.88% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.27% <ø> (ø)
Services 99.53% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.53% <100.00%> (+0.13%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce2a59...63fda55. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented May 1, 2024 •
edited

Bundle Report

Changes will increase total bundle size by 37.97kB ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.56MB 37.97kB ⬆️

@codecov Codecov
Copy link

codecov bot commented May 1, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (4ce2a59) to head (63fda55).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2826   +/-   ##
=====================================
  Coverage   98.48   98.48           
=====================================
  Files        869     870    +1     
  Lines      12729   12758   +29     
  Branches    3359    3428   +69     
=====================================
+ Hits       12535   12564   +29     
  Misses       190     190           
  Partials       4       4
Files Coverage Δ
src/ui/Card/Card.tsx 100.00% <100.00%> (ø)
src/ui/RadioTileGroup/RadioTileGroup.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.88% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.27% <ø> (ø)
Services 99.53% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.53% <100.00%> (+0.13%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce2a59...63fda55. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented May 1, 2024 •
edited

Bundle Report

Changes will increase total bundle size by 37.97kB ⬆️

Bundle name Size Change
gazebo-production-array-push 6.56MB 37.97kB ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented May 1, 2024 •
edited

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
a2d7109 Wed, 01 May 2024 20:35:38 GMT Expired Expired
83202d2 Wed, 01 May 2024 21:15:22 GMT Expired Expired
6cb29db Wed, 01 May 2024 21:47:46 GMT Expired Expired
f3ff905 Wed, 01 May 2024 22:00:25 GMT Expired Expired
3191ae6 Thu, 02 May 2024 13:58:24 GMT Expired Expired
fa4dd9b Thu, 02 May 2024 15:53:27 GMT Expired Expired
63fda55 Fri, 03 May 2024 17:41:36 GMT Cloud Enterprise

nicholas-codecov
nicholas-codecov reviewed May 2, 2024
View reviewed changes
Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick few things to take a peak at

src/ui/RadioTileGroup/RadioTileGroup.spec.tsx Outdated Show resolved Hide resolved
src/ui/RadioTileGroup/RadioTileGroup.spec.tsx Outdated Show resolved Hide resolved
src/ui/RadioTileGroup/RadioTileGroup.stories.tsx Outdated Show resolved Hide resolved
src/ui/RadioTileGroup/RadioTileGroup.tsx Outdated Show resolved Hide resolved
@spalmurray-codecov spalmurray-codecov changed the title Implement RadioTileGroup component feat: Implement RadioTileGroup component May 2, 2024
@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/radio-tile-component branch 2 times, most recently from 3191ae6 to fa4dd9b Compare May 2, 2024 15:42
@codecov-notifications
Copy link

codecov-notifications bot commented May 2, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2826   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         869      870    +1     
  Lines       12729    12758   +29     
  Branches     3423     3364   -59     
=======================================
+ Hits        12535    12564   +29     
  Misses        190      190           
  Partials        4        4
Files Coverage Δ
src/ui/Card/Card.tsx 100.00% <100.00%> (ø)
src/ui/RadioTileGroup/RadioTileGroup.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 55.88% <ø> (ø)
Layouts 97.25% <ø> (ø)
Pages 99.27% <ø> (ø)
Services 99.53% <ø> (ø)
Shared 99.84% <ø> (ø)
UI 94.53% <100.00%> (+0.13%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce2a59...63fda55. Read the comment docs.

nicholas-codecov
nicholas-codecov approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit 4a402db May 3, 2024
59 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/radio-tile-component branch May 3, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholas-codecov nicholas-codecov nicholas-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spalmurray-codecov @codecov-releaser @nicholas-codecov