Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show installation help banner in global banners #2702

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Mar 14, 2024

Description

The last change had to be reverted #2691 as it failed on null providers. This change adds a check to ensure a provider exists similar to RequestInstallBanner.

  • test on enterprise

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov-public-qa bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb29149) 98.44% compared to head (ce4fa3d) 98.44%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2702   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files         854      854           
  Lines       11938    11939    +1     
  Branches     3099     3099           
=======================================
+ Hits        11752    11753    +1     
  Misses        183      183           
  Partials        3        3           
Files Coverage Δ
.../InstallationHelpBanner/InstallationHelpBanner.tsx 100.00% <100.00%> (ø)
src/shared/GlobalTopBanners/GlobalTopBanners.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.14% <100.00%> (+<0.01%) ⬆️
Pages 99.33% <ø> (ø)
Services 99.61% <ø> (ø)
Shared 99.83% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb29149...ce4fa3d. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.44%. Comparing base (bb29149) to head (ce4fa3d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2702   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files         854      854           
  Lines       11938    11939    +1     
  Branches     3132     3097   -35     
=======================================
+ Hits        11752    11753    +1     
  Misses        183      183           
  Partials        3        3           
Files Coverage Δ
.../InstallationHelpBanner/InstallationHelpBanner.tsx 100.00% <100.00%> (ø)
src/shared/GlobalTopBanners/GlobalTopBanners.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.14% <100.00%> (+<0.01%) ⬆️
Pages 99.33% <ø> (ø)
Services 99.61% <ø> (ø)
Shared 99.83% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb29149...ce4fa3d. Read the comment docs.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.44%. Comparing base (bb29149) to head (ce4fa3d).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2702   +/-   ##
=====================================
  Coverage   98.44   98.44           
=====================================
  Files        854     854           
  Lines      11938   11939    +1     
  Branches    3142    3142           
=====================================
+ Hits       11752   11753    +1     
  Misses       183     183           
  Partials       3       3           
Files Coverage Δ
.../InstallationHelpBanner/InstallationHelpBanner.tsx 100.00% <100.00%> (ø)
src/shared/GlobalTopBanners/GlobalTopBanners.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 55.55% <ø> (ø)
Layouts 97.14% <100.00%> (+<0.01%) ⬆️
Pages 99.33% <ø> (ø)
Services 99.61% <ø> (ø)
Shared 99.83% <ø> (ø)
UI 94.17% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb29149...ce4fa3d. Read the comment docs.

@rohitvinnakota-codecov rohitvinnakota-codecov changed the title Show installation help banner Show installation help banner in global banners Mar 14, 2024
@codecov-releaser
Copy link
Contributor

codecov-releaser commented Mar 14, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Commit Created Cloud Enterprise
ce4fa3d Thu, 14 Mar 2024 16:59:43 GMT Expired Expired
ce4fa3d Thu, 14 Mar 2024 17:00:35 GMT Expired Expired
ce4fa3d Thu, 14 Mar 2024 17:04:53 GMT Expired Expired
ce4fa3d Thu, 14 Mar 2024 17:05:12 GMT Expired Expired
ce4fa3d Thu, 14 Mar 2024 18:53:23 GMT Cloud Enterprise

@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review March 14, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants