feat: Team plan repos list #2357
Conversation
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2357 +/- ##
=======================================
- Coverage 96.98 96.97 -0.01
=======================================
Files 733 734 +1
Lines 8866 8940 +74
Branches 2144 2209 +65
=======================================
+ Hits 8598 8669 +71
- Misses 265 266 +1
- Partials 3 5 +2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2357 +/- ##
==========================================
- Coverage 96.97% 96.96% -0.01%
==========================================
Files 733 734 +1
Lines 8866 8940 +74
Branches 2190 2222 +32
==========================================
+ Hits 8598 8669 +71
- Misses 265 267 +2
- Partials 3 4 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2357 +/- ##
=======================================
Coverage ? 97.16%
=======================================
Files ? 727
Lines ? 8756
Branches ? 2176
=======================================
Hits ? 8508
Misses ? 245
Partials ? 3
Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2357 +/- ##
==========================================
- Coverage 96.97% 96.96% -0.01%
==========================================
Files 733 734 +1
Lines 8866 8940 +74
Branches 2195 2178 -17
==========================================
+ Hits 8598 8669 +71
- Misses 264 267 +3
Partials 4 4
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
* feat: add header component for team tier customers * feat: converted Header.jsx to Header.tsx + tests * fix: add comparison schema types
Filter out events for a given browser because they don't have all JS functions fully implemented causing issues that we cannot address.
…2327) We will need to hide the flag multi select on the commit detail page when the user is on the team plan as they are not an available feature to those users. GH codecov/engineering-team#687
…an (#2329) Disable the flag multi-select on the coverage tab when users/orgs are on a team plan. GH codecov/engineering-team#685
…2335) Update indirect changes tab on the commit detail page to grab flags from the url params and pass along as query args. GH codecov/engineering-team#348
…2334) Update the files changed tab on the commit detail page to grab flags url param and pass along as query args. GH codecov/engineering-team#347
* Update with service less requests * Make sure hook supports service less * feat: Add Flag MultiSelect to CommitPageTabs (#2303) Add a feature flagged multi select to the CommitPageTabs component. GH codecov/engineering-team#344 * Add patch column to pulls table (#2308) * feat: add patch column to the pulls list page * uncomment development settings * feat: Create Team Plan Table for the Files Changed Table on the Commit Detail Page (#2309) Create new commit fetching hooks for the team plan, as well as creating a new table for files changed tab on the commit detail page for the new team plan. GH codecov/engineering-team#633 * Setup pull request page to pass around selected flags (#2282) * feat: setup pull request page to pass around selected flags in links * Feedback, fix passing links to files+folders, additional testing * fix file explorer test failing on href match due to new query param pass through * airplane commit, cant check local dev server: Resolve merge issues / tests + unify codebases missed of commitSHA and commitSha to just commitSha * Prevent multislect from collapsing + wire up PR details page to pass through flags links * Fix accidental removal of ref on usePrefetchPullFileEntry * Add patch column to pulls table (#2308) * feat: add patch column to the pulls list page * uncomment development settings * feat: Create Team Plan Table for the Files Changed Table on the Commit Detail Page (#2309) Create new commit fetching hooks for the team plan, as well as creating a new table for files changed tab on the commit detail page for the new team plan. GH codecov/engineering-team#633 --------- Co-authored-by: Adrian <[email protected]> Co-authored-by: nicholas-codecov <[email protected]> * chore: Remove segment from frontend (#2314) * Update with tests * test with support service less * adjust logic to handle original route * it's fine it works with no providers --------- Co-authored-by: nicholas-codecov <[email protected]> Co-authored-by: Adrian <[email protected]> Co-authored-by: Terry <[email protected]>
Update PostCSS dependency.
* Migrate textinput to TS * Add story * formatting * organize imports
* feat: Update impacted files resolver for use pull, connect the flag selector to the api. * update missing logic as requested + unknown flags message to be aligned with repo overview design * Noticed the changing the pull query broke impacted files while smoke testing, dupicated the same compatibility work for the new resolver. * Refactor to use a impacted files enum as requested.
Addressing flaky tests in CommitDetailPage and RepoPage.
* restructure folders anticipating second header component for team tier * feat: add patch coverage section to commit detail page for team tier customer * fix: rename HeaderDefault to HeaderTeam for team file
* Convert sparkline to typescript * Consistent type defs * better variable names
| @@ -197,4 +197,26 @@ describe('OrgControlTable', () => { | |||
| expect(screen.queryByText(/RepoOrgNotFound/)).not.toBeInTheDocument() | |||
| }) | |||
| }) | |||
|
|
|||
| describe('when show team plan passed in', () => { | |||
| it('does nto render the ordering select', () => { | |||
| const state = sorting.at(0) | ||
|
|
||
| if (state) { | ||
| const direction = state?.desc |
There was a problem hiding this comment.
Do you need state? since you are already checking if state is defined. All good if the IDE is showing an error though.
| ] | ||
| } | ||
| return [ | ||
| columnHelper.accessor('name', { |
There was a problem hiding this comment.
Consider splitting this into its own variable so you only have to declare it once. Then you can do something like
const nameColumn = columnHelper.accessor('name', {
header: 'Name',
id: 'name',
...
and then
return [nameColumn, columnHelper.accessor(...), etc].
This will help reduce repeated code in the same file and help with readability.
| isCurrentUserPartOfOrg: isCurrentUserPartOfOrg, | ||
| }), | ||
| getCoreRowModel: getCoreRowModel(), | ||
| data: tableData ?? [], |
There was a problem hiding this comment.
?? [] is advised against in the Tanstack Table docs, because if you provide just the empty array it will just create an infinite loop like we were running into before. Can you update the useMemo above to handle the case when table data maybe undefined or null.
Something along the lines:
const tableData = useMemo(
() => {
const data = reposData?.pages?.map((page) => page?.repos).flat()
return data ?? []
},
[reposData?.pages]
)
| const repoDisplay = useContext(ActiveContext) | ||
| const activated = | ||
| repoDisplayOptions[ | ||
| repoDisplay.toUpperCase() as keyof typeof repoDisplayOptions | ||
| ]?.status |
There was a problem hiding this comment.
Can you create a ticket noted down to refactor this context to Typescript and then remove this casting here, just so it's tracked and we can remove it down the road. As well as noting this specific code section here in the ticket.
You can link this doc here for doing context in a typesafe manner.
Description
Introducing the new table for the team plan, with the following features different:
Notable Changes
Screenshots
Screen.Recording.2023-10-30.at.10.58.21.AM.mov
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.