Optimize save_report_lines a bit
#62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## swatinem/codspeed-bench #62 +/- ##
========================================================
Coverage 98.52% 98.52%
========================================================
Files 21 21
Lines 6772 6775 +3
========================================================
+ Hits 6672 6675 +3
Misses 100 100
☔ View full report in Codecov by Sentry. |
Swatinem
force-pushed
the
swatinem/opt-save
branch
from
0fd0baf to
3319a51
Compare
CodSpeed Performance ReportMerging #62 will not alter performanceComparing Summary
|
Swatinem
force-pushed
the
swatinem/codspeed-bench
branch
from
54cbaa6 to
251cf8e
Compare
This avoids some intermediate allocations in particular for a `flag_map` case, as well as avoiding another allocation. In other cases its unfortunately not possible to avoid more intermediate allocations.
Swatinem
force-pushed
the
swatinem/opt-save
branch
from
3319a51 to
7b80699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids some intermediate allocations in particular for a
flag_mapcase, as well as avoiding another allocation.In other cases its unfortunately not possible to avoid more intermediate allocations.