-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add sentry to bundler plugins #72
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in the 'bundler-plugin-core' package look good overall. It incorporates Sentry integration for collecting traces and metrics, and this has been done consistently and systematically across the application's core functions. Moreover, it introduces neatly encapsulated utility functions for Sentry client generation, options normalization, and Sentry-enabled fetch retries. A critical thing to note, however, is the magic string Sentry DSN within the createSentryInstance function. This could benefit from refactoring to isolate it as a constant or config file variable to avoid potential security risks and code readability.
packages/bundler-plugin-core/src/bundle-analysis/bundleAnalysisPluginFactory.ts
Show resolved
Hide resolved
packages/bundler-plugin-core/src/bundle-analysis/bundleAnalysisPluginFactory.ts
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just a comment about the metrics API, but otherwise looks solid. Thanks for taking a look at this!
packages/bundler-plugin-core/src/bundle-analysis/bundleAnalysisPluginFactory.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
48e19a8
to
d513ce1
Compare
Bundle ReportChanges will increase total bundle size by 5.43kB ⬆️
|
5720f96
to
ddb2c1d
Compare
… for different bundler
8564ffb
to
6799747
Compare
Description
This PR adds in Sentry to collect traces and metics for the bundler plugins
Closes codecov/engineering-team#954
Notable Changes