Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Vite V6 #230

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

nicholas-codecov
Copy link
Collaborator

@nicholas-codecov nicholas-codecov commented Dec 17, 2024

Description

This PR upgrades versions around so that we're adding in support for Vite V6, alongside we're also bringing in support for Astro V5. As well this PR updates various other dependencies bringing them up to date, and resolving other peer dep issues.

Closes #222

Notable Changes

  • Modify Vite plugins peer deps to support V6
  • Change type in the Nuxt plugin to support
  • Add in support for Astro V5 (with example and integration tests)
  • Move from defineProject to defineConfig in Vitest configs as there are less type issues
  • Lot of dep updates
    • Focused on bringing everything up to date with Vite V6
    • Bring other out of date deps up to date to resolve peer deps

@codecov-staging
Copy link

codecov-staging bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
packages/nuxt-plugin/src/index.ts 0.00% 2 Missing ⚠️
packages/astro-plugin/src/index.ts 0.00% 1 Missing ⚠️
Components Coverage Δ
Plugin core 98.69% <ø> (+1.17%) ⬆️
Rollup plugin 9.58% <ø> (-1.19%) ⬇️
Vite plugin 9.81% <ø> (-1.13%) ⬇️
Webpack plugin 61.33% <ø> (+9.24%) ⬆️

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.54%. Comparing base (6c4a0ce) to head (eb282ed).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
packages/nuxt-plugin/src/index.ts 0.00% 2 Missing ⚠️
packages/astro-plugin/src/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
Components Coverage Δ
Plugin core 98.69% <ø> (+1.17%) ⬆️
Rollup plugin 9.58% <ø> (-1.19%) ⬇️
Vite plugin 9.81% <ø> (-1.13%) ⬇️
Webpack plugin 61.33% <ø> (+9.24%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

codecov-staging bot commented Dec 23, 2024

Bundle Report

Changes will increase total bundle size by 401.0kB (6.93%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
@codecov/example-next-15-app-edge-server-array-push 6.22kB 5.86kB (1647.19%) ⬆️⚠️
@codecov/bundler-plugin-core-esm 12.43kB 40.73kB (-76.61%) ⬇️
@codecov/example-next-15-app-server-cjs 477.97kB 118.86kB (33.1%) ⬆️⚠️
@codecov/nuxt-plugin-esm 1.23kB 397 bytes (47.83%) ⬆️⚠️
@codecov/solidstart-plugin-esm 1.09kB 142 bytes (14.96%) ⬆️⚠️
@codecov/remix-vite-plugin-esm 957 bytes 133 bytes (-12.2%) ⬇️
@codecov/example-next-15-app-client-array-push 1.03MB 99.73kB (10.67%) ⬆️⚠️
@codecov/example-vite-app-esm 151.39kB 683 bytes (0.45%) ⬆️
@codecov/example-nuxt-app-client-esm 246.19kB 6.28kB (2.62%) ⬆️
@codecov/example-nuxt-app-server-esm 347.95kB 175 bytes (-0.05%) ⬇️
@codecov/example-solidstart-app-esm 34.06kB 365 bytes (1.08%) ⬆️
@codecov/example-tokenless-app-esm 151.37kB 703 bytes (0.47%) ⬆️
@codecov/example-sveltekit-app-client-esm 727.49kB 12.4kB (1.73%) ⬆️
@codecov/example-solidstart-app-client-esm 48.14kB 230 bytes (0.48%) ⬆️
@codecov/example-sveltekit-app-server-esm 984.45kB 10.16kB (1.04%) ⬆️
@codecov/example-solidstart-app-server-esm 79.3kB 372 bytes (0.47%) ⬆️
@codecov/example-astro-5-app-client-esm 185.87kB 185.87kB (100%) ⬆️⚠️
View changes by path for bundle: @codecov/example-next-15-app-server-cjs
File path Size Change
/ 58.41kB 319 bytes (0.55%)
View changes by path for bundle: @codecov/example-sveltekit-app-client-esm
File path Size Change
/about 1.2kB 372 bytes (-23.66%)
/ 10.79kB 3.47kB (-24.32%)
/sverdle/how-to-play 2.0kB 354 bytes (-15.06%)
/sverdle 15.39kB 2.02kB (-11.58%)
View changes by path for bundle: @codecov/example-sveltekit-app-server-esm
File path Size Change
/about 1.07kB 124 bytes (-10.36%)
/ 13.24kB 14.94kB (-53.02%)
/sverdle/how-to-play 1.87kB 4.73kB (-71.69%)
/sverdle 152.48kB 17.0kB (-10.03%)

Copy link

codecov bot commented Dec 23, 2024

Bundle Report

Changes will increase total bundle size by 399.67kB (6.73%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
@codecov/vite-plugin-esm 1.24kB 1.13kB (-47.66%) ⬇️
@codecov/bundler-plugin-core-esm 12.43kB 40.73kB (-76.61%) ⬇️
@codecov/nuxt-plugin-esm 1.23kB 397 bytes (47.83%) ⬆️⚠️
@codecov/sveltekit-plugin-esm 891 bytes 198 bytes (-18.18%) ⬇️
@codecov/example-solidstart-app-esm 34.06kB 365 bytes (1.08%) ⬆️
@codecov/example-vite-app-esm 151.39kB 683 bytes (0.45%) ⬆️
@codecov/webpack-plugin-esm 3.6kB 209 bytes (6.17%) ⬆️⚠️
@codecov/example-solidstart-app-client-esm 48.14kB 230 bytes (0.48%) ⬆️
@codecov/example-nuxt-app-client-esm 246.19kB 6.28kB (2.62%) ⬆️
@codecov/solidstart-plugin-esm 1.09kB 142 bytes (14.96%) ⬆️⚠️
@codecov/example-sveltekit-app-client-esm 727.49kB 12.4kB (1.73%) ⬆️
@codecov/example-sveltekit-app-server-esm 984.45kB 10.16kB (1.04%) ⬆️
@codecov/example-solidstart-app-server-esm 79.3kB 372 bytes (0.47%) ⬆️
@codecov/example-nuxt-app-server-esm 347.95kB 175 bytes (-0.05%) ⬇️
@codecov/example-next-15-app-edge-server-array-push 6.22kB 5.86kB (1647.19%) ⬆️⚠️
@codecov/example-next-15-app-client-array-push 1.03MB 99.73kB (10.67%) ⬆️⚠️
@codecov/example-next-15-app-server-cjs 477.97kB 118.86kB (33.1%) ⬆️⚠️
@codecov/example-tokenless-app-esm 151.37kB 703 bytes (0.47%) ⬆️
@codecov/bundle-analyzer-esm 3.11kB 347 bytes (-10.05%) ⬇️
@codecov/example-astro-5-app-client-esm 185.87kB 185.87kB (100%) ⬆️⚠️
View changes by path for bundle: @codecov/example-sveltekit-app-client-esm
File path Size Change
/ 10.79kB 3.47kB (-24.32%)
/sverdle 15.39kB 2.02kB (-11.58%)
/sverdle/how-to-play 2.0kB 354 bytes (-15.06%)
/about 1.2kB 372 bytes (-23.66%)
View changes by path for bundle: @codecov/example-next-15-app-server-cjs
File path Size Change
/ 58.41kB 319 bytes (0.55%)
View changes by path for bundle: @codecov/example-sveltekit-app-server-esm
File path Size Change
/ 13.24kB 14.94kB (-53.02%)
/sverdle 152.48kB 17.0kB (-10.03%)
/sverdle/how-to-play 1.87kB 4.73kB (-71.69%)
/about 1.07kB 124 bytes (-10.36%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Vite v6
1 participant