Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Sentry to the bundler plugins #224

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

nicholas-codecov
Copy link
Collaborator

@nicholas-codecov nicholas-codecov commented Dec 6, 2024

Description

This PR adds in the first iteration of Sentry to the bundler plugins, however, this PR does not include adding Sentry to the bundler-analyzer as that will come in a following PR as that requires a bit more work to sorted and this PR was getting big enough as it is.

Ticket: codecov/engineering-team#954

Notable Changes

  • Create Sentry helper utils and telemetry unplugin plugin - Followed along from: feat: Update Sentry telemetry to v8 getsentry/sentry-javascript-bundler-plugins#604
  • Add some spans to the Output to track some initial data points
  • Add telemetry plugin to all bundler plugins
    • Disabled telemetry from running on the integration tests
  • Fix for NextJS plugin, where we weren't using the correct webpack as we should have been doing.
    • This was included as it was causing type issues
  • Create/Update tests

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 6, 2024

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 60.14670% with 326 lines in your changes missing coverage. Please review.

Project coverage is 75.99%. Comparing base (90901a5) to head (2543234).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
packages/remix-vite-plugin/src/index.ts 0.00% 33 Missing ⚠️
packages/solidstart-plugin/src/index.ts 0.00% 33 Missing ⚠️
packages/sveltekit-plugin/src/index.ts 0.00% 33 Missing ⚠️
packages/astro-plugin/src/index.ts 0.00% 32 Missing ⚠️
packages/nuxt-plugin/src/index.ts 0.00% 31 Missing ⚠️
packages/vite-plugin/src/index.ts 0.00% 29 Missing ⚠️
packages/nextjs-webpack-plugin/src/index.ts 0.00% 25 Missing ⚠️
packages/rollup-plugin/src/index.ts 0.00% 24 Missing ⚠️
packages/webpack-plugin/src/index.ts 0.00% 24 Missing ⚠️
...ckages/bundler-plugin-core/src/sentry/telemetry.ts 90.00% 19 Missing ⚠️
... and 12 more
Additional details and impacted files
Components Coverage Δ
Plugin core 96.49% <92.29%> (-0.49%) ⬇️
Rollup plugin 8.92% <13.79%> (-1.85%) ⬇️
Vite plugin 8.92% <11.76%> (-2.01%) ⬇️
Webpack plugin 49.26% <12.90%> (-2.84%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

codecov-staging bot commented Dec 6, 2024

Bundle Report

Changes will increase total bundle size by 3.01MB (109.53%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
@codecov/bundler-plugin-core-cjs 64.05kB 5.04kB (8.55%) ⬆️⚠️
@codecov/bundler-plugin-core-esm 14.41kB 1.97kB (15.86%) ⬆️⚠️
@codecov/vite-plugin-cjs 3.16kB 317 bytes (11.16%) ⬆️⚠️
@codecov/nuxt-plugin-esm 1.56kB 726 bytes (87.47%) ⬆️⚠️
@codecov/webpack-plugin-cjs 4.97kB 326 bytes (7.02%) ⬆️⚠️
@codecov/solidstart-plugin-cjs 1.71kB 382 bytes (28.81%) ⬆️⚠️
@codecov/sveltekit-plugin-cjs 1.7kB 381 bytes (28.86%) ⬆️⚠️
@codecov/nuxt-plugin-cjs 1.75kB 351 bytes (25.05%) ⬆️⚠️
@codecov/nextjs-webpack-plugin-cjs 2.6kB 485 bytes (22.96%) ⬆️⚠️
@codecov/rollup-plugin-cjs 3.19kB 330 bytes (11.56%) ⬆️⚠️
@codecov/remix-vite-plugin-cjs 1.69kB 377 bytes (28.71%) ⬆️⚠️
@codecov/astro-plugin-cjs 1.7kB 351 bytes (26.08%) ⬆️⚠️
@codecov/example-tokenless-app-esm 150.67kB 150.67kB (100%) ⬆️⚠️
@codecov/example-bundle-analyzer-esm 1.41kB 1.41kB (100%) ⬆️⚠️
@codecov/example-nuxt-app-server-esm 348.12kB 348.12kB (100%) ⬆️⚠️
@codecov/example-bundle-analyzer-cli 511 bytes 511 bytes (100%) ⬆️⚠️
@codecov/example-solidstart-app-client-esm 47.91kB 47.91kB (100%) ⬆️⚠️
@codecov/example-solidstart-app-server-esm 78.93kB 78.93kB (100%) ⬆️⚠️
@codecov/example-remix-app-client-esm 251.34kB 251.34kB (100%) ⬆️⚠️
@codecov/example-remix-app-server-esm 12.56kB 12.56kB (100%) ⬆️⚠️
@codecov/example-bundle-analyzer-cjs 1.41kB 1.41kB (100%) ⬆️⚠️
@codecov/example-sveltekit-app-server-esm 974.29kB 974.29kB (100%) ⬆️⚠️
@codecov/example-sveltekit-app-client-esm 715.09kB 715.09kB (100%) ⬆️⚠️
@codecov/example-astro-app-client-esm 144.27kB 144.27kB (100%) ⬆️⚠️
@codecov/example-solidstart-app-esm 33.7kB 33.7kB (100%) ⬆️⚠️
@codecov/example-nuxt-app-client-esm 239.9kB 239.9kB (100%) ⬆️⚠️

Copy link

codecov bot commented Dec 6, 2024

Bundle Report

Changes will increase total bundle size by 10.4kB (0.18%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/vite-plugin-cjs 3.16kB 317 bytes (11.16%) ⬆️
@codecov/remix-vite-plugin-cjs 1.69kB 377 bytes (28.71%) ⬆️
@codecov/remix-vite-plugin-esm 1.45kB 488 bytes (50.99%) ⬆️
@codecov/bundler-plugin-core-cjs 64.05kB 5.04kB (8.55%) ⬆️
@codecov/bundler-plugin-core-esm 14.41kB 1.97kB (15.86%) ⬆️
@codecov/rollup-plugin-cjs 3.19kB 330 bytes (11.56%) ⬆️
@codecov/nuxt-plugin-cjs 1.75kB 351 bytes (25.05%) ⬆️
@codecov/nuxt-plugin-esm 830 bytes 397 bytes (-32.36%) ⬇️
@codecov/sveltekit-plugin-cjs 1.7kB 381 bytes (28.86%) ⬆️
@codecov/webpack-plugin-cjs 4.97kB 326 bytes (7.02%) ⬆️
@codecov/solidstart-plugin-cjs 1.71kB 382 bytes (28.81%) ⬆️
@codecov/example-sveltekit-app-client-esm 715.09kB 2 bytes (-0.0%) ⬇️
@codecov/nextjs-webpack-plugin-cjs 2.6kB 485 bytes (22.96%) ⬆️
@codecov/astro-plugin-cjs 1.7kB 351 bytes (26.08%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant