ref: Optimize file fetching code #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| headers: { | ||
| "Accept": "application/json", | ||
| }, | ||
| }).then((response) => response.json()); |
| if (commit.length === 7) { | ||
| const commitLink = document.querySelector( | ||
| `[href^="/${groups.owner}/${groups.repo}/tree/${commit}"]` | ||
| ); |
There was a problem hiding this comment.
the long sha can be found inside a few links on this page, that's what this code extracts.
| @@ -232,40 +269,6 @@ async function process(metadata: FileMetadata): Promise<void> { | |||
| animateAndAnnotateLines(noVirtLineSelector, annotateLine); | |||
| } | |||
|
|
|||
| async function promptPastReport(metadata: FileMetadata): Promise<void> { | |||
There was a problem hiding this comment.
There will never be a need for this code anymore. This was called when the metadata for a branch gave the HEAD commit and there was no coverage for that HEAD commit. If you're on a branch now, Codecov will handle this on the API side and give you the last good coverage.
| .closest("div")!; | ||
| const dropdownButton = editButton.cloneNode(true) as HTMLElement; | ||
| const textNode: HTMLElement = dropdownButton.querySelector('[data-component="IconButton"]')!; | ||
| // Build the button out of the Raw/copy/download button group |
There was a problem hiding this comment.
If you're looking at a file at a commit, the old button we were building from does not exist. I adjusted the code to use a button that exists on both types of view (the raw/copy/download group). Additionally, I made the code a bit safer by removing !s
nicholas-codecov
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking around in here I noticed we were doing a whole extra fetch to get the metadata for the file when all of the info we need was already present on the page. This PR updates the code to remove that fetch. Additionally, adds support for file coverage when browsing at a specific commit, this was previously not supported.