feat: Use uv package manager #988
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suejung-sentry
commented
Nov 20, 2024
| @@ -57,6 +56,7 @@ FROM self-hosted as self-hosted-runtime | |||
| USER root | |||
| ARG EXTERNAL_DEPS_FOLDER=./external_deps | |||
| RUN mkdir $EXTERNAL_DEPS_FOLDER | |||
| # TODO - replace the pip install here? | |||
There was a problem hiding this comment.
TODO - look into the build for self-hosted?
suejung-sentry
force-pushed
the
sshin/uv
branch
5 times, most recently
from
7022337 to
eac6df1
Compare
suejung-sentry
commented
Nov 21, 2024
| description = "Codecov's API layer" | ||
| readme = "README.md" | ||
| requires-python = ">=3.12" | ||
| dependencies = [ |
There was a problem hiding this comment.
TODO - these are ported over to align with existing requirements.in. Go through and pin these to max versions in existing requirements.txt so not introducing any regressions by using an old version of deps
fix celery
suejung-sentry
force-pushed
the
sshin/uv
branch
from
eac6df1 to
0bd1c5f
Compare
suejung-sentry
force-pushed
the
sshin/uv
branch
from
9a67ab5 to
d6067c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
apito use a more modern package manager (uv). This will let us more easily convert to monolith in the future.Shared is getting converted in here: codecov/shared#423
Worker is getting converted in here: codecov/worker#896
Notable changes
requirements.in1:1 into new pyproject.toml to use uv-tools for build instead of pip-compile. Any deps that appeared to be used for dev only were added todev-dependencies. The new lockfile will beuv.locksentry-sdk[celery]to fix its build error. As long as we useCeleryIntegration, can remove the custom wrapping with_wrap_asyncCloses codecov/engineering-team#2779