Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set max wait time at 10 seconds #538

Merged
merged 4 commits into from May 3, 2024

Conversation

thomasrockhu-codecov
Copy link
Contributor

Purpose/Motivation

Problem
Some users on the bash/v1/uploader/v3 uploaders are running into problems. This seems to be manifesting in that the builds take FOREVER to run.

Root Cause
Looking at most logs, you will notice that we fail when pinging Codecov for the upload URL (see image). But wait, it says wait almost 3600 seconds?? That seems wrong. After all we run with the normal retry logic (roughly exponential backoff up to 10 seconds).
This means that the bash/v1/uploader/v3 is receiving a different retry time. You can find that logic here

            raise exceptions.Throttled(
                wait=retry_after,
                detail="Rate limit reached. Please upload with the Codecov repository upload token to resolve issue.",
            )

Solution
This PR sets the max wait time as 10 seconds.

Links to relevant tickets

fixes codecov/feedback#354

What does this PR do?

This PR sets the max wait time as 10 seconds.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@thomasrockhu-codecov thomasrockhu-codecov requested a review from a team as a code owner May 3, 2024 02:08
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.79%. Comparing base (271d368) to head (88b7428).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #538   +/-   ##
=====================================
  Coverage   95.79   95.79           
=====================================
  Files        777     777           
  Lines      17228   17228           
=====================================
  Hits       16502   16502           
  Misses       726     726           
Flag Coverage Δ
unit 91.51% <ø> (ø)
unit-latest-uploader 91.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (271d368) to head (88b7428).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #538   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files         602      602           
  Lines       16372    16372           
=======================================
  Hits        14983    14983           
  Misses       1389     1389           
Flag Coverage Δ
unit 91.51% <ø> (ø)
unit-latest-uploader 91.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (271d368) to head (88b7428).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #538   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files         602      602           
  Lines       16372    16372           
=======================================
  Hits        14983    14983           
  Misses       1389     1389           
Flag Coverage Δ
unit 91.51% <ø> (ø)
unit-latest-uploader 91.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
upload/tokenless/github_actions.py 98.27% <ø> (ø)

Impacted file tree graph

@thomasrockhu-codecov thomasrockhu-codecov added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit 61a953b May 3, 2024
21 checks passed
@thomasrockhu-codecov thomasrockhu-codecov deleted the th/dont-add-wait-for-retry branch May 3, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Codecov v1 action freezes jobs when uploading report
2 participants