fix: set max wait time at 10 seconds #538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
Problem
Some users on the bash/v1/uploader/v3 uploaders are running into problems. This seems to be manifesting in that the builds take FOREVER to run.
Root Cause
Looking at most logs, you will notice that we fail when pinging Codecov for the upload URL (see image). But wait, it says wait almost 3600 seconds?? That seems wrong. After all we run with the normal retry logic (roughly exponential backoff up to 10 seconds).
This means that the bash/v1/uploader/v3 is receiving a different retry time. You can find that logic here
Solution
This PR sets the max wait time as 10 seconds.
Links to relevant tickets
fixes codecov/feedback#354
What does this PR do?
This PR sets the max wait time as 10 seconds.
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.