Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding logs for debugging #536

Merged
merged 3 commits into from May 6, 2024
Merged

Conversation

nora-codecov
Copy link
Contributor

Purpose/Motivation

Temporary logs for debugging OIDC auth

@nora-codecov nora-codecov requested a review from a team as a code owner May 2, 2024 02:16
@nora-codecov nora-codecov force-pushed the nora/troubleshoot-oidc-with-logs branch from 5670090 to f5866c4 Compare May 2, 2024 02:18
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.79%. Comparing base (ab808c1) to head (138c3ce).

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Files Patch % Lines
upload/helpers.py Critical 83.33% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #536   +/-   ##
=====================================
  Coverage   95.79   95.79           
=====================================
  Files        777     777           
  Lines      17232   17252   +20     
=====================================
+ Hits       16506   16525   +19     
- Misses       726     727    +1     
Flag Coverage Δ
unit 91.52% <95.65%> (+<0.01%) ⬆️
unit-latest-uploader 91.52% <95.65%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-qa
Copy link

codecov-qa bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.52%. Comparing base (ab808c1) to head (138c3ce).

✅ All tests successful. No failed tests found.

Files Patch % Lines
upload/helpers.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #536   +/-   ##
=======================================
  Coverage   91.51%   91.52%           
=======================================
  Files         602      602           
  Lines       16376    16396   +20     
=======================================
+ Hits        14987    15006   +19     
- Misses       1389     1390    +1     
Flag Coverage Δ
unit 91.52% <95.65%> (+<0.01%) ⬆️
unit-latest-uploader 91.52% <95.65%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.52%. Comparing base (ab808c1) to head (138c3ce).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #536   +/-   ##
=======================================
  Coverage   91.51%   91.52%           
=======================================
  Files         602      602           
  Lines       16376    16396   +20     
=======================================
+ Hits        14987    15006   +19     
- Misses       1389     1390    +1     
Flag Coverage Δ
unit 91.52% <95.65%> (+<0.01%) ⬆️
unit-latest-uploader 91.52% <95.65%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/authentication/repo_auth.py 98.58% <100.00%> (+0.10%) ⬆️
upload/helpers.py 94.32% <83.33%> (-0.26%) ⬇️

Impacted file tree graph

joseph-sentry
joseph-sentry previously approved these changes May 2, 2024
Copy link
Contributor

@joseph-sentry joseph-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure debug level logs will show up in the logs since i don't think our log level is at debug in prod and staging (but i'm not sure about other envs) but the changes lgtm

@nora-codecov
Copy link
Contributor Author

@joseph-sentry dang good call - I assumed we were collecting all logs but looking at the log explorer, looks like we aren't including debug level

@codecov-notifications
Copy link

codecov-notifications bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 lines in your changes are missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
upload/helpers.py 83.33% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

adrian-codecov
adrian-codecov previously approved these changes May 3, 2024
Copy link

@barnett-yuxiang barnett-yuxiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nora-codecov nora-codecov force-pushed the nora/troubleshoot-oidc-with-logs branch from 6c0c108 to 3c7ce5f Compare May 6, 2024 17:59
@nora-codecov nora-codecov force-pushed the nora/troubleshoot-oidc-with-logs branch from 3c7ce5f to 138c3ce Compare May 6, 2024 19:36
@nora-codecov nora-codecov added this pull request to the merge queue May 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2024
@nora-codecov nora-codecov added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit dab39b5 May 6, 2024
18 of 20 checks passed
@nora-codecov nora-codecov deleted the nora/troubleshoot-oidc-with-logs branch May 6, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants