Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add migrate shell script to encapsulate migration logic #427

Merged
merged 15 commits into from May 6, 2024

Conversation

adrian-codecov
Copy link
Contributor

Purpose/Motivation

On top of the usual django migrate.py script we usually run, we're adding another django command that creates DB partitions. Because of that, we're creating a dedicated script to run these commands

What does this PR do?

  • Add a migrate.sh shell script with migration logic
  • Adjust dev + staging scripts to call the migrate scripts
  • Ensure we delete that migration script from the dockerfile

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-qa
Copy link

codecov-qa bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (5077d4e) to head (89c44e6).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #427   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files         602      602           
  Lines       16376    16376           
=======================================
  Hits        14987    14987           
  Misses       1389     1389           
Flag Coverage Δ
unit 91.51% <ø> (ø)
unit-latest-uploader 91.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.51%. Comparing base (5077d4e) to head (89c44e6).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #427   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files         602      602           
  Lines       16376    16376           
=======================================
  Hits        14987    14987           
  Misses       1389     1389           
Flag Coverage Δ
unit 91.51% <ø> (ø)
unit-latest-uploader 91.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted file tree graph

trent-codecov
trent-codecov previously approved these changes Feb 29, 2024
@codecov-staging
Copy link

codecov-staging bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.79%. Comparing base (5077d4e) to head (89c44e6).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #427   +/-   ##
=====================================
  Coverage   95.79   95.79           
=====================================
  Files        777     777           
  Lines      17232   17232           
=====================================
  Hits       16506   16506           
  Misses       726     726           
Flag Coverage Δ
unit 91.51% <ø> (ø)
unit-latest-uploader 91.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrian-codecov adrian-codecov added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 1e1cc99 May 6, 2024
19 checks passed
@adrian-codecov adrian-codecov deleted the 1259-add-migrate-script branch May 6, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants