Allow for Database options to be set via config #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is especially needed for Postgres 15 where by default users are no longer allowed to write to schema `public`. Being able to set options enables switching to another default schema (e.g. `codecov`)
|
Thank you for the submission. @scott-codecov will take a look at this sometime soon and we will get this rolling. |
| @@ -217,6 +231,7 @@ | |||
| "HOST": DATABASE_READ_HOST, | |||
| "PORT": DATABASE_READ_PORT, | |||
| "CONN_MAX_AGE": CONN_MAX_AGE, | |||
| "OPTIONS": ast.literal_eval(DATABASE_READ_OPTIONS), | |||
There was a problem hiding this comment.
Could this be a json.loads instead here instead?
There was a problem hiding this comment.
Sure - would then be a more restricted format, though.
There was a problem hiding this comment.
In what sense? Were you hoping to pass in Python literals that can't be encoded as JSON?
There was a problem hiding this comment.
Were you hoping to pass in Python literals that can't be encoded as JSON?
Not really. I think I can life with JSON just fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
This is especially needed for Postgres 15 where by default users are no longer allowed to write to schema
public. Being able to set options enables switching to another default schema (e.g.codecov)Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.