Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate some django_apps to shared #1089

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

Swatinem
Copy link
Contributor

This effects the following: compare, labelanalysis, profiling and staticanalysis

The models and factories are re-exported from shared, and the MIGRATION_MODULES is properly set up so that the migrations are being imported and ran from shared, and the local migrations are thus being removed.


This depends on codecov/shared#469

@Swatinem Swatinem self-assigned this Jan 10, 2025
@Swatinem Swatinem requested a review from a team as a code owner January 10, 2025 12:10
Copy link
Contributor

This PR includes changes to shared. Please review them here: codecov/shared@c3288a0...c1c9cb2

Copy link
Contributor

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.99%. Comparing base (4c41647) to head (4f1d28e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1089      +/-   ##
==========================================
- Coverage   96.02%   95.99%   -0.04%     
==========================================
  Files         831      831              
  Lines       19563    19407     -156     
==========================================
- Hits        18785    18629     -156     
  Misses        778      778              
Flag Coverage Δ
unit 92.17% <100.00%> (-0.16%) ⬇️
unit-latest-uploader 92.17% <100.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codecov/shared#469 (review), as long as they seem good then I'm 👌

This effects the following: `compare`, `labelanalysis`, `profiling` and `staticanalysis`

The models and factories are re-exported from `shared`, and the `MIGRATION_MODULES` is properly set up so that the migrations are being imported and ran from `shared`, and the local migrations are thus being removed.
@Swatinem Swatinem force-pushed the swatinem/mv-migrations-shared branch from a969c66 to 4f1d28e Compare January 14, 2025 08:51
Copy link
Contributor

This PR includes changes to shared. Please review them here: codecov/shared@a03c2f9...de4b37b

@Swatinem Swatinem added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 8e1adbc Jan 14, 2025
18 of 19 checks passed
@Swatinem Swatinem deleted the swatinem/mv-migrations-shared branch January 14, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants