Update logrus from v0.8.7 to v1.0.5 #344
Open
+180,430
−1,321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fix building on SmartOS.
|
Hi @alyssais! Thank you for looking into this. Can you sign the CLA? |
|
Done! |
|
Hi! Noticed there's been some activity on this repo recently. Anything else I need to do before this can be merged? |
|
@alyssais sorry on the late follow up. Any chance you can rebase from master? I want to publish a beta binary and try this out in our CI for a day before releasing. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to report CodeClimate test results from a CI server running on SmartOS.
Since there's no official Solaris binary, I tried to build one myself. This didn't work, but after a while I found that all that was needed to get the build working was to update logrus to the latest version!