Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only install enabled engines #936

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Only install enabled engines #936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
759b6df
Only install enabled egines
nextrevision Jan 14, 2020
c93996e
Simplifying select statement
nextrevision Jan 14, 2020
ec50c31
Adding test coverage for excluding disabled images from engines:insta…
nextrevision Jan 14, 2020
a76c8e9
Merge branch 'master' into patch-1
nextrevision Aug 17, 2022
688685d
Merge branch 'master' into patch-1
nextrevision Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/cc/cli/engines/install.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def config
end

def pull_docker_images
config.engines.each(&method(:pull_engine))
config.engines.select(&:enabled?).each(&method(:pull_engine))
end

def pull_engine(engine)
Expand Down
16 changes: 16 additions & 0 deletions spec/cc/cli/engines/install_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,22 @@ module CC::CLI::Engines
expect { install.run }.to raise_error(Install::ImagePullFailure)
end
end

it "excludes disabled images" do
write_cc_yaml(YAML.dump("plugins" => { "madeup" => true, "structure" => false }))
stub_engine_registry(YAML.dump(
"structure" => { "channels" => { "stable" => "structure" } },
"duplication" => { "channels" => { "stable" => "duplication" } },
"madeup" => { "channels" => { "stable" => "madeup" } },
))

install = Install.new

expect_system(install, "docker pull duplication")
expect_system(install, "docker pull madeup")

capture_io { install.run }
end
end

def expect_system(install, cmd, result = true)
Expand Down