-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (progress log) - users can keep track of their learnings and share with other members of SG. #688
base: staging
Are you sure you want to change the base?
Conversation
@distalx Sorry for the slowness looking at this. I pushed up some styling improvements (more standardized and easier-to-read on-the-page alerts and info boxes, and cursor pointer for edit/delete). I'm still struggling with naming: does What would you vote for? Also, general UI feedback welcome -- I'd like to continue to put up the "Please share something you learned or accomplished" reminder, but maybe it should be full width. |
…le, slug, and description in DB so that we can see the ID in tweetLog
... and depending on what terminology we decide, the tweet will either say:
|
Thanks for enabling auto-tweets for logs. Should we add a sort of notice on the log submission modal that this will be tweeted by CB's twitter account? re:
Very roughly:
I've update that. RE : terminology I thought that Initially, we are creating this functionality for the organiser or host of the hangout to log the short summery of the hangout, so if some member miss the hangout they can easily catch up with the group by going through these log entries. for that use case |
check(id, String); | ||
|
||
let query = new Object(); | ||
query['study_group.id'] = id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why we're using bracket notation here and dot-notation everywhere else? We should be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the schema of the progress log is as follows.
{
_id : String,
title : String,
study_group : [Object]
}
So if we want to fetch progress log by a study groups our find query would be against the field study_group.id
.
query['study_group.id'] = '22'
will result in {study_group.id: "22"}
here JS runs toString() on square brackets so we could use special characters into our keys.
with dot-notation
that does not seem to be feasible.
@lpatmo I think notes feels more appropriate to me in this context. That's my vote. |
Hi guys, A couple of things:
|
@julianjohannesen On #1: It'd be great if you could log an issue on it! Thank you! On #2: Noted. :) On #3: 100%. I think we do support wysiwyg here (similar to what you see when you start a hangout). |
@distalx sup? |
Fixes #642