i18n use monent relative time concept #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i18n use monent relative time concept
|
hm... I should change test as well, later. |
retrieve test
|
retrieved tests, ‘1 second’ and'xx seconds' now will be 'a few seconds' which comes from moment i18n file, I think this is not perfect. |
|
Hey, have you checked if "german (de)" is working for the i18n? |
…n-concept change to have i18n with relative time from moment
|
Hi, @cmalard , the modified files conflicts with current version. Conflicting files Should fix the conficts based on current version, sometime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, it nice to find moment-precise-range, but it doesn't support i18n, so I added i18n support with monent relative time concept.
One thing not good is that, now 'a' will replace '1', eg. '1 month' -> 'a month'
but moment did like this, make be it will change in the future, probably moment-precise-range with i18n support can still work.