feat: Library Management System files and test files #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonydmays
requested changes
Mar 25, 2024
| @@ -9,8 +10,15 @@ | |||
| /** Represents a library. */ | |||
| public class Library { | |||
There was a problem hiding this comment.
Great attempt at supporting the new requirements, color me impressed! However, I'd like to see you implement a single method that allows you to checked out any type of library asset without having to know whether it's a book, dvd, magazine, or etc. You can do this using the right interface.
| import com.codedifferently.lesson10.library.exceptions.WrongLibraryException; | ||
|
|
||
|
|
||
| public class Librarian { |
There was a problem hiding this comment.
A librarian should be treated like any other patron of the library. That's a hint that you should consider using inheritance to implement this functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was not able to finish the library test entirely