Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chapters not showing after reload #2761

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

4yman-0
Copy link

@4yman-0 4yman-0 commented Jan 1, 2025

Fix #2754

ImprovedTube.chapters tries to call ImprovedTube.forbidFocus which does not exists or is not a function. Tested with Chromium on Arch Linux and random youtube videos.

Fix code-charity#2754

`ImprovedTube.chapters` tries to call `ImprovedTube.forbidFocus` which does not exists or is not a function.
Tested with Chromium on Arch Linuxand random youtube videos.
@4yman-0 4yman-0 requested a review from ImprovedTube January 1, 2025 07:26
@4yman-0

This comment was marked as off-topic.

@ImprovedTube
Copy link
Member

thank you! @4yman-0 glad you are here! sorry this one seems to be a duplicate of #2750

@4yman-0
Copy link
Author

4yman-0 commented Jan 2, 2025

How is this a duplicate?
This PR sets forbidFocus initialy while your commits make improvedTube.chapters set forbidFocus EVERY, SINGLE, TIME it is called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞Chapters not show in sidebar
2 participants