Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix options menu size #2673

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

4yman-0
Copy link

@4yman-0 4yman-0 commented Nov 12, 2024

Should fix #2569

TODO:

NOTES:

Unfortunately, https://improvedtube.com/wishes is broken and I can't fix it here.

Edit: I think flexbox is grid now

@4yman-0

This comment was marked as outdated.

@4yman-0 4yman-0 self-assigned this Nov 12, 2024
@4yman-0 4yman-0 requested a review from ImprovedTube November 13, 2024 15:33
@ImprovedTube
Copy link
Member

hi! :) @4yman-0

we can start a proper "wishes" here on Github! (CTRL+U)

just to make sure, you might knew the 9 buttons used to be equal sizes 3 x 3.
While different sizes now make some sense, the current CSS position adjustments are binding the page to the static 320px width.

@4yman-0

This comment was marked as outdated.

@ImprovedTube
Copy link
Member

hi!
sorry i mean, this is what most of all users see currently (the new sizes and order are reasoned)
2024
(All of 2024, thus most important already?)
(previously: 3 x 3 (tidy and most years) and 1 x 5 (first 5 years))

(done quickly, this also required to set a max-width for full-tabs chrome-extension://bnomihfieiccainjcjblhegjgglakjdd/menu/index.html, which is fine, since more width doesn't help.
and the remaining space can be used better in a full tab)

Will be very worth it to start working on our GUI.
Eventually we can also provide full tab menu with player, playlists & history #1546 https://github.com/code-charity/History-Manager

broken after a canceled "export settings"

/what did you mean?

@ImprovedTube
Copy link
Member

starting at #2569: The scrollbar at chrome://extensions/?options=bnomihfieiccainjcjblhegjgglakjdd
can be avoided with a bit less height (520px?), which can be conditional there, because when clicking the browser icon 600px are allowed (and might be more convenient?)

@4yman-0
Copy link
Author

4yman-0 commented Nov 15, 2024

/what did you mean?

Plz don't just respond to issue comments in the request.
As for the "breaking":

  1. Go to "Settings"
  2. Choose "Backup"
  3. Choose "Export settings"
  4. Cancel it (should open menu full-tab)

@4yman-0

This comment was marked as resolved.

@4yman-0
Copy link
Author

4yman-0 commented Nov 15, 2024

@ImprovedTube Any proposals to fix stuff or something (users used to the current layout will be confused).

EDIT 1: Remove stuff

@ImprovedTube
Copy link
Member

yes, i mean

  • used to be 3x3;
    • since almost 1 year: Decreasing size of buttons, thus taking less space, allowing 4 in the second row.
    • so in future we might not only want to undo to 3 x 3, but also analyse / keep benefits of the current version? 🤔

Cancel it (should open menu full-tab)

yes, that's currently unnecessary

@4yman-0
Copy link
Author

4yman-0 commented Nov 17, 2024

So in future we might not only want to undo to 3 x 3, but also analyse / keep benefits of the current version? 🤔

So, we want to let users know "Hey, these 2 buttons are important, the next 4 are OK and last 2 are pretty useless".

Probably do some sort of styling that doesn't make it like "Look, a grid!!1!".

@4yman-0
Copy link
Author

4yman-0 commented Nov 18, 2024

We're so back

Here's how it looks like w/ display:flex;width: w%.

chrome-extension___dhggbdhnjdpaeogjfkpebfmjmdlkjmhe_menu_index html

And it does not overflow in normal popup 🎉 !

@4yman-0
Copy link
Author

4yman-0 commented Dec 5, 2024

Problem still exists in Master.

@4yman-0
Copy link
Author

4yman-0 commented Dec 10, 2024

I pulled updates in the OTHER pull request and wow. Look at this error message :)

Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-NiECYfW4hZvoiuPCi8Qfv/CQOQ+CSiskRAxXo6dieJk='), or a nonce ('nonce-...') is required to enable inline execution.

Context menu/index.html
Stack Trace menu/index.html:35 (anonymous function)

 <script> if (window.location.href.includes('chrome://extensions/?options=')) {
    body.style.setProperty('height', '523px', 'important');
    body.style.setProperty('width', '396px', 'important');
  } 
</script> 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞Broken options page layout
2 participants