Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed load event to DOMContentLoaded #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

changed load event to DOMContentLoaded #3

wants to merge 2 commits into from

Conversation

MAZ01001
Copy link
Contributor

changed the load event to DOMContentLoaded which might be a bit faster since it does not wait for the entire page to load...

The DOMContentLoaded event fires when the HTML document has been completely parsed, and all deferred scripts (<script defer src="…"> and <script type="module">) have downloaded and executed. It doesn't wait for other things like images, subframes, and async scripts to finish loading.
[...]
A different event, load, should be used only to detect a fully-loaded page. It is a common mistake to use load where DOMContentLoaded would be more appropriate.

→ MDN: DOMContentLoaded event

@MAZ01001
Update yt_popup_player.md
5404bee 
changed the "load" event to a "DOMContentLoaded" event
@MAZ01001
Merge branch 'code-charity:main' into yt-popup
80b5610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MAZ01001