-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommend DistSender concurrency limit bump #19096
base: main
Are you sure you want to change the base?
Conversation
Fixes DOC-11652 Summary of changes: - Update 'Performance Recipes' page to note that if you encounter DistSender batch throttling (`distsender.batches.async.throttled` is > 0), consider increasing the value of the `kv.dist_sender.concurrency_limit` cluster setting.
Files changed: |
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
❌ Deploy Preview for cockroachdb-docs failed. Why did it fail? →
|
Hey @sean- @nhamlani101 @mwang1026 this is a quick rough draft to address https://cockroachlabs.atlassian.net/browse/DOC-11652 which was prompted by a message from @sean- IMO to get this into docs, we need to answer a couple questions/make some decisions (below list of things are also marked
|
Something like: "If
"To validate a successful result, you can increase this value until you see no new throttled requests AND no increase in tail latency (e.g. p99.999)." This does increase the amount of RAM consumption per node to handle the increased concurrency, but it's proportional to the load and an individual flow's memory consumption isn't "significant." Bad outcomes include increased tail latency or too much memory consumption with no decrease in the number of throttled requests.
Heh, good to know, and yes agreed about making it public. |
Fixes DOC-11652
Summary of changes:
distsender.batches.async.throttled
is > 0), consider increasing the value of thekv.dist_sender.concurrency_limit
cluster setting.