-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gci/: Redesign gci students web-page #252
base: master
Are you sure you want to change the base?
Conversation
429c2b7
to
f964107
Compare
Travis tests have failedHey @KVGarg, 1st Build./.ci/build.sh
TravisBuddy Request Identifier: 362dec80-8d20-11e9-94f5-3d756601374f |
f71693f
to
48b07dd
Compare
Travis tests have failedHey @KVGarg, TravisBuddy Request Identifier: 868a5970-9009-11e9-a59a-63c971f4d69b |
48b07dd
to
51c9795
Compare
02727d5
to
bf49527
Compare
dbb8ec1
to
23442d7
Compare
b893898
to
a5c7b4d
Compare
Travis tests have failedHey @KVGarg, 1st Build./.ci/build.sh
TravisBuddy Request Identifier: 25124190-b380-11e9-a522-656c855f12dd |
a5c7b4d
to
98abd01
Compare
Travis tests have failedHey @KVGarg, 1st Build./.ci/build.sh
TravisBuddy Request Identifier: 59c0bba0-b38b-11e9-a522-656c855f12dd |
40e68a9
to
9020b08
Compare
Travis tests have failedHey @KVGarg, 1st Build./.ci/build.sh
TravisBuddy Request Identifier: 99b0e820-b3ae-11e9-a522-656c855f12dd |
9bac8da
to
1d98f8b
Compare
Travis tests have failedHey @KVGarg, 1st Buildcoala --non-interactive -V
TravisBuddy Request Identifier: ad21b520-b4f7-11e9-a172-292526d14dc1 |
5e7fa12
to
9648e17
Compare
The updation in model adds new data fields which will be useful, in further work. Also, it will reduce the API calls, which are being made to fetch these information. Instead of making new API Calls, we can get them from webservices and use them directly.
The openhub module got disabled due to some reasons in community project last year. And, currently the module is raising the CI errors which need to be avoided. They can be worked on once we're ready to enable the openhub module once again in this project in future.
As in future, the data will be fetched from coala-webservices intead of @sks444 repository (webservices.coala.io). So, to remove that dependency the tests have been modified accordingly.
Running command ".ci/build.sh" locally on pc used to failed the build, if there is more than one git remote's. Fixes coala#235
9648e17
to
ea65671
Compare
The enhancement includes addition of materialize css, JQuery, responsiveness, and easy-navigation of website features. The easy-navigatibility is achieved by adding a navbar with display of meta -review and gamification leaderboard on homepage. Apart from this, the activity graph url is omitted from website by displaying the graph itslef on the homepage on large devices. Closes coala#255
ea65671
to
4c26fc1
Compare
The newly created webpage combines the previous two webpages- info.txt and log/index.html. This web-page combines the results of both the pages and shows them in a better UI/UX with additional features of filtering and searching within the existing logs. The logs are fetched from a JSON file which is created from the logs stored in the log file _site/community.log Closes coala#256
4c26fc1
to
6bc955e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc @li-boxuan
The redesigned web-page displays the data in a better UI/UX form with some additional information to make it more interactive and attractive. Closes coala#257
6bc955e
to
5f86b09
Compare
<li><a href="{{ org.twitter_url }}" target="_blank"><i class="fa fa-twitter social-icons"></i></a></li> | ||
<li><a href="{{ org.facebook_url }}" target="_blank"><i class="fa fa-facebook-f social-icons"></i></a></li> | ||
<li><a href="{{ org.repo_url }}" target="_blank"><i class="fa fa-github social-icons"></i></a></li> | ||
<li><a class="dropdown-trigger" href="#user" data-target="user-dropdown"><i class="fa fa-user social-icons"></i></a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you using this? IMO even if related to future use then it can easily be added in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, not being used here! But eventually in #263 where the OAuth will be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh okay fine great 👍
The redesigned web-page displays the data
in a better UI/UX form with some additional
information to make it more interactive and
attractive.
Closes https://gitlab.com/coala/GSoC/gsoc-2019/issues/269