persist and maintain front matter #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- on import, track front matter in staging table if parsed - work core Chronicles metadata (tags, title, dates) into front matter - maintain front matter in documents (keep existing, merge Chronicles properties) - refactor: migrate rest of client.documents to knex - refactor: parse and stringify frontmatter tags as valid yaml - add micromark front matter libraries and prefer them when parsing / serializing
- migrate internal tracking and updating of title, createdAt, updatedAt, and tags to frontMatter - heavily refactor import, sync, create, and update interfaces to account the changes
- remove legacy CACHE_DIR key; update DATABSE_URL reference - fix issue with default journal setting on import - fix navigate back from loading screen - track and log documents saves Future change should be smarter about saving documents, reducing fs writes and alllowing user to leave note view while save runs in background
cloverich
force-pushed
the
importer_updates
branch
from
aa5c207 to
e5d1f35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was originally aiming just to complete #259 but along the way realized fully maintaining would probably be required, and scoped an hour and was mostly completed. Untested when this was opened.
Closes #259
Foundation for #127
Part of #256 (probably)