Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When syncing ignore more files and directories, refactor walk #281

Merged
merged 4 commits into from
Dec 9, 2024
Merged

When syncing ignore more files and directories, refactor walk #281

merged 4 commits into from
Dec 9, 2024

Conversation

cloverich
Copy link
Owner

  • refactor: drop klaw, replace with nodes fs.opendir
  • dont descend into directories we don't intend to sync (hidden folders like .git, node_modules, _attachments in sync specifically)
  • Add more ignored files / folders and indicate which are skipped in preferences (todo: make configurable)
  • refactor: drop mkdirp (after discovering it mostly exists in fs now)

Closes #279
Closes #274

@cloverich
refactor directory traversal
42ef2fc 
- refactor: drop klaw and replace with nodes opendir in Files.walk
- skip descending into non-syncable directories and add many more excluded folders and prefixes
@cloverich
list skipped items in preferences
52fa08c
@cloverich
refactor: drop mkdirp
2a9a035
@cloverich
mkdirp edge case
37cc19b
@cloverich cloverich merged commit f494a5d into master Dec 9, 2024
2 checks passed
@cloverich cloverich deleted the ignore_git branch December 9, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not crawl .git or other hidden directories in sync or import drop mkdirp and klaw
1 participant
@cloverich