Import non-Notion markdown directory #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First commit preparing for non-Notion markdown import (e.g. Obsidian import). - add sourceType to importer - conditionally strip and track notion Id from note title
- skip front matter parsing when not Notion (existing routine is _very_ Notion specific) - skip title parsing from front matter; fallback to file name when non-Notion import - rely on ctime / mtime for created at and updated at by stubbing empty front matter
cloverich
changed the title
- update wikilink (mdast) url to the resolved url - convert wiikilink from ofmWikiEmbedding to image Almost works, but intermediate step will die trying to write mdast back to markdown.
- move all file handling and update logic to WikiFileResolver - change order of update / file move operations somewhat - convert ofmWiki links and embedding (naively) - complete first Obsidian import test (partial, focused on images, it works) Next some refactoring, a fuller test, then Wikilinks, then edge case searching
- convert wiki-style note links to markdown-style note links - update internal note links to updated note location - make import type (Notion, Other) configurable via UI - use birthtime, else mtime, for note creation date
- check for empty / null value when selecting new chronicles root - it implies the user clicked cancel
- when importing, parse #tags in content and convert to document tags on create - add supporting libraries (temporarily forked into project, b/c esm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds experimental support for non-Notion markdown import (e.g. Obsidian import). Goal is to allow me to import all my old markdown notes from two directories (one is a Notion, other is Apple Notes -> Obsidian) in a basic (experimental) sense. #258 and #271 were relevant pre-cursors to this branch. See #247 for motivation.
![[My File.webp]]) to markdown links[[My other note]]) to markdown-based note links([[../My relative link]]). Presumably from duplicate filenames.Will most likely defer handling duplicate / relative wikilinks if I don't have personal need. Will be better prepared to tackle them after #251 since that probably requires some related refactoring.
Closes #132