clean-up dropdown styling and usage #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor journal and date selectors in FrontMatter to use radix- based dropdown / popover instead of evergreen - move Dropdown / Popover to base components to reflect wider usage intent - refactor context menu (in sidebar) to use tailwind, and use same bg / text classes as other menus These changes will make it easier to move theme / restyle in the future Also: - fix (remove) an inline code style that changed line height when typing inline code in the editor
cloverich
changed the title
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will make it easier to move theme / restyle in the future. Probably two follow-up clean-up items:
InlineCombobox, which doesn't share the styles, and uses ariakit combobox; probably want to in-house it or use something more stable (Clean-up ariakit/combobox and InlineCombobox #238 )Also:
Closes #221
Part of #215