add sidebar and journal click-to-search #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloverich
commented
Jan 21, 2024
src/views/documents/SearchStore.ts
Outdated
| * i.e. search documents in one folder | ||
| */ | ||
| searchJournal = (journalName: string) => { | ||
| const tokens = this._tokens.filter((t) => t.type !== "in"); |
There was a problem hiding this comment.
Ah, this should actually behave more like setTokens. If you:
- have an active multi-part search
- click sidebar and select a new journal
It should wipe the whole search, leaving only in:.
There was a problem hiding this comment.
Opted for a setSearch method, although perhaps simply replace is better (i.e. searchStore.replace).
- add sidebar to main view with journals - add setSearch behavior to search store - add "click to search", where clicking populates an in: search tag for only that journal
cloverich
force-pushed
the
journal-sidebar
branch
from
ed8d5af to
4e8ee48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #119
Behavior works similar to sidebar in any folder-based journaling app. Clicking folder icon next to search opens the sidebar; clicking a journal in the sidebar replaces the current search with
in:<selected journal>. I don't like the UI but its functional.Sidebar button; used folder icon since its only for selecting journals as of now...
Clicking any journal replaces the current search:
