NGINX Identity Aware Proxy #202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… templates to follow
- adds required nginx resolver - adds required oauth2 whitelist_domain - builds internal service hostname from reordered original hostname
aknysh
reviewed
May 1, 2019
| @@ -0,0 +1,4 @@ | |||
| apiVersion: v1 | |||
| description: A Helm chart for Kubernetes | |||
aknysh
reviewed
May 1, 2019
| @@ -0,0 +1,26 @@ | |||
| kind: Pod | |||
There was a problem hiding this comment.
are the files in pr123 folder just examples?
how they are going to be deployed?
maybe just move to examples in README?
aknysh
reviewed
May 1, 2019
|
|
||
| {{/* | ||
| Create a default fully qualified oauth name. | ||
| We limit this value to 24 chars because some Kubernetes name fields are limited to this (by the DNS naming spec). |
There was a problem hiding this comment.
no trunc 24 here, should add it or update the description
aknysh
reviewed
May 1, 2019
| We limit this value to 24 chars because some Kubernetes name fields are limited to this (by the DNS naming spec). | ||
| */}} | ||
| {{- define "fullname_oauth" -}} | ||
| {{- printf "%.17s-oauth" .Release.Name | trimSuffix "-" -}} |
aknysh
reviewed
May 1, 2019
|
|
||
| {{/* | ||
| Create a default fully qualified proxy name. | ||
| We truncate at 24 chars because some Kubernetes name fields are limited to this (by the DNS naming spec). |
There was a problem hiding this comment.
no trunc 24 here, should add it or update the description
aknysh
reviewed
May 1, 2019
| {{- end -}} | ||
|
|
||
| {{/* | ||
| Create a default fully qualified proxy name. |
There was a problem hiding this comment.
Suggested change
| Create a default fully qualified proxy name. | |
| Create a default fully qualified ingress name. |
aknysh
reviewed
May 1, 2019
|
|
||
| {{/* | ||
| Create a default fully qualified proxy name. | ||
| We truncate at 24 chars because some Kubernetes name fields are limited to this (by the DNS naming spec). |
There was a problem hiding this comment.
no trunc 24 here, should add it or update the description
aknysh
reviewed
May 1, 2019
| We truncate at 24 chars because some Kubernetes name fields are limited to this (by the DNS naming spec). | ||
| */}} | ||
| {{- define "fullname_ingress" -}} | ||
| {{- printf "%.16s-ingress" .Release.Name | trimSuffix "-" -}} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.