Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add PopupMenu #690

Open
wants to merge 53 commits into
base: main
Choose a base branch
from
Open

feat(ui): add PopupMenu #690

wants to merge 53 commits into from

Conversation

franzheidl
Copy link
Contributor

@franzheidl franzheidl commented Dec 19, 2024

Summary

Add a new PopupMenu component to replace Menu(and related) as well as ContextMenu components.

The new PopupMenu component wraps Headless UI's Menu component with a consistent API, while rendering its menu part into our own portal provided by PortalProvider.

The deprecated components will now output deprecation warnings.

Changes Made

  • add PopupMenu component
  • deprecate Menu, MenuSection, MenuItem, and ContextMenu components.

Related Issues

Screenshots (if applicable)

Screenshot 2024-12-19 at 14 40 07

Testing Instructions

  1. npm i
  2. npm run test-vitest PopupMenu
  3. npm run storybook

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

Copy link

changeset-bot bot commented Dec 19, 2024

🦋 Changeset detected

Latest commit: 4270b69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-ui-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 19, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://cloudoperators.github.io/juno/pr-preview/pr-690/
on branch gh-pages at 2024-12-19 15:34 UTC

@franzheidl franzheidl changed the title add PopupMenu feat(ui): add PopupMenu Dec 19, 2024
@franzheidl franzheidl marked this pull request as ready for review December 19, 2024 12:57
@franzheidl franzheidl requested a review from a team as a code owner December 19, 2024 12:57
@barsukov barsukov changed the title feat(ui): add PopupMenu feat(ui123): add PopupMenu Dec 19, 2024
@barsukov barsukov changed the title feat(ui123): add PopupMenu feat(ui): add PopupMenu Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant