Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fixes glob import of scss files #686

Merged
merged 4 commits into from
Dec 18, 2024
Merged

fix(ui): fixes glob import of scss files #686

merged 4 commits into from
Dec 18, 2024

Conversation

andypf
Copy link
Collaborator

@andypf andypf commented Dec 18, 2024

Summary

This PR resolves a regression that occurred while transitioning to Vite, which affected the ability to use glob imports for all SCSS files within the components directory. The fix ensures that SCSS files are properly imported maintaining the expected behavior and styling consistency.

Changes Made

  • Remove glob import from global.scss
  • Import all scss files from components manually via @use

Related Issues

Testing Instructions

  1. npm i
  2. npm run TASK

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@andypf andypf requested review from franzheidl and a team as code owners December 18, 2024 13:48
Copy link

changeset-bot bot commented Dec 18, 2024

🦋 Changeset detected

Latest commit: cb7a277

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-ui-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ArtieReus ArtieReus added the ui-components All tasks related to juno-ui-components library label Dec 18, 2024
Copy link
Contributor

github-actions bot commented Dec 18, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-18 15:24 UTC

edda
edda previously approved these changes Dec 18, 2024
Copy link
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changeset?

@andypf andypf closed this Dec 18, 2024
@andypf andypf reopened this Dec 18, 2024
@andypf andypf closed this Dec 18, 2024
@andypf andypf reopened this Dec 18, 2024
@andypf andypf merged commit baccd3c into main Dec 18, 2024
25 checks passed
@andypf andypf deleted the andypf-fix-css branch December 18, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-components All tasks related to juno-ui-components library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants