-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(supernova): refactor localItems, client.js, serviceApi, and processingStatus to use React Query #680
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: df3ade6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This refactoring looks promising! Thank you! I’ve tested the UI despite the broken UI components, and I’d like to share my initial findings:
- The alerts list only displays active alerts.
- When silencing an alert from the alerts list, a success message is shown. However, the alert disappears from the list immediately, making it unclear whether the alert was successfully silenced, as it is no longer displayed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, a lot of code deleted more clear way. Few comments from my side 🥇
Summary
Closes #681
Changes Made
Testing Instructions
npm i
npm run TASK
Checklist