-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ui): integrate vite for ui-components #673
Conversation
🦋 Changeset detectedLatest commit: 71242a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@taymoor89 I create an extra ticket for the lefotver typechek, So i will resolve the comments because as you can see the PR is already very big and I think we can do follow ups on this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing. I'd like to understand some of the necessary changes in the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good overall, Thank You. Just have a few questions on changes not in requirements or explanation, would prefer to leave those lines untouched... unless we're sure? 🙏🚀💪
We agreed on current state of art and we will proceed with new defaultProps strategy
Summary
This pull request transitions the project from Rollup to Vite as the primary bundler to improve build performance and developer experience. It maintains backward compatibility while ensuring existing workflows remain functional. The Storybook configuration remains untouched for now, with plans to update it in a subsequent iteration.
Changes Made
Related Issues
Screenshots (if applicable)
Testing Instructions
npm install
to install updated dependencies.npm run build
to verify the Vite setup.Checklist
This marks the initial step toward optimizing our build process with Vite while keeping Storybook configurations pending for a future update.