Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): integrate vite for ui-components #673

Merged
merged 16 commits into from
Dec 12, 2024
Merged

Conversation

barsukov
Copy link
Contributor

Summary

This pull request transitions the project from Rollup to Vite as the primary bundler to improve build performance and developer experience. It maintains backward compatibility while ensuring existing workflows remain functional. The Storybook configuration remains untouched for now, with plans to update it in a subsequent iteration.

Changes Made

  • Removed Rollup as the bundler.
  • Fully integrated Vite as the new bundler across the project.
  • Ensured backward compatibility with existing configurations and workflows.

Related Issues

Screenshots (if applicable)

Testing Instructions

  1. Run npm install to install updated dependencies.
  2. Execute npm run build to verify the Vite setup.
  3. Test backward compatibility with previous configurations.

Checklist

  • Performed a self-review of the changes.
  • Verified backward compatibility with existing setups.
  • Added comments for any complex sections of code.
  • Updated or ensured no changes were required for documentation.
  • Tested locally, and all unit tests pass.
  • Ensured no new warnings or errors are introduced.

This marks the initial step toward optimizing our build process with Vite while keeping Storybook configurations pending for a future update.

@barsukov barsukov self-assigned this Dec 10, 2024
@barsukov barsukov requested review from franzheidl and a team as code owners December 10, 2024 14:55
Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: 71242a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-ui-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@barsukov barsukov changed the title Wowa vite UI components chore(ui): integrate vite for ui-components Dec 10, 2024
Copy link
Contributor

github-actions bot commented Dec 10, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-12 15:46 UTC

@barsukov barsukov marked this pull request as draft December 11, 2024 07:37
@barsukov barsukov added ui-components All tasks related to juno-ui-components library draft labels Dec 11, 2024
@barsukov barsukov marked this pull request as ready for review December 11, 2024 08:47
apps/carbon/src/App.tsx Show resolved Hide resolved
apps/template/src/App.tsx Outdated Show resolved Hide resolved
apps/template/src/App.tsx Show resolved Hide resolved
@barsukov
Copy link
Contributor Author

@taymoor89 I create an extra ticket for the lefotver typechek, So i will resolve the comments because as you can see the PR is already very big and I think we can do follow ups on this one.

@barsukov
Copy link
Contributor Author

@taymoor89 #678

taymoor89
taymoor89 previously approved these changes Dec 11, 2024
andypf
andypf previously approved these changes Dec 11, 2024
Copy link
Contributor

@guoda-puidokaite guoda-puidokaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing. I'd like to understand some of the necessary changes in the PR.

Copy link
Contributor

@guoda-puidokaite guoda-puidokaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good overall, Thank You. Just have a few questions on changes not in requirements or explanation, would prefer to leave those lines untouched... unless we're sure? 🙏🚀💪

apps/template/src/App.tsx Outdated Show resolved Hide resolved
apps/template/src/App.tsx Outdated Show resolved Hide resolved
apps/template/src/App.tsx Outdated Show resolved Hide resolved
apps/template/src/components/AppContent.tsx Outdated Show resolved Hide resolved
@barsukov barsukov dismissed stale reviews from andypf and taymoor89 via 60ff0dc December 12, 2024 09:46
apps/template/src/App.tsx Outdated Show resolved Hide resolved
apps/template/src/App.tsx Outdated Show resolved Hide resolved
@barsukov barsukov removed the draft label Dec 12, 2024
@barsukov barsukov dismissed guoda-puidokaite’s stale review December 12, 2024 15:43

We agreed on current state of art and we will proceed with new defaultProps strategy

@barsukov barsukov requested review from taymoor89 and andypf December 12, 2024 15:44
@barsukov barsukov merged commit 3c6ad30 into main Dec 12, 2024
15 checks passed
@barsukov barsukov deleted the wowa-vite-ui-components branch December 12, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-components All tasks related to juno-ui-components library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants