Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(supernova): introducing ReactQuery #658

Merged
merged 18 commits into from
Dec 6, 2024
Merged

Conversation

TilmanHaupt
Copy link
Contributor

@TilmanHaupt TilmanHaupt commented Dec 3, 2024

Summary

Closes #628
Closes #659

  • The alerts worker is removed.
  • The silences worker is removed.
  • React Query is successfully integrated for fetching alerts data.
  • Generalized Bounding for React Query is successfully integrated for fetching alerts data
  • The fetching interval remains consistent with the worker's behavior.
  • The results fetched by React Query match the existing data structure and are stored in the Zustand store.
  • All existing components relying on the Zustand store remain functional without modification.
  • Loading and error states are now deleted and we now use reactQuery states
  • Errors for Alerts are now show in messages.

Testing Instructions

  1. npm i
  2. npm run TASK

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@TilmanHaupt TilmanHaupt requested a review from a team as a code owner December 3, 2024 15:39
Copy link

changeset-bot bot commented Dec 3, 2024

🦋 Changeset detected

Latest commit: 3e8a716

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-app-supernova Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 3, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-06 14:40 UTC

Copy link
Collaborator

@andypf andypf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job, but pleas address my comments.

apps/supernova/src/App.jsx Show resolved Hide resolved
apps/supernova/src/AppContent.jsx Outdated Show resolved Hide resolved
apps/supernova/src/AppContent.jsx Outdated Show resolved Hide resolved
apps/supernova/src/components/AsyncWorker.jsx Outdated Show resolved Hide resolved
apps/supernova/src/components/alerts/AlertsList.jsx Outdated Show resolved Hide resolved
apps/supernova/src/components/alerts/AlertsList.jsx Outdated Show resolved Hide resolved
apps/supernova/src/components/silences/SilencesList.jsx Outdated Show resolved Hide resolved
@andypf andypf changed the title refactor(supernova): Introducing ReactQuery refactor(supernova): introducing ReactQuery Dec 3, 2024
@ArtieReus ArtieReus added the supernova All tasks related to supernova label Dec 4, 2024
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great work, I agree with everything what @andypf said so please fix the issues and we could merge it.

Copy link
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As described in the comments

apps/supernova/src/App.jsx Outdated Show resolved Hide resolved
apps/supernova/src/workers/alerts.js Outdated Show resolved Hide resolved
apps/supernova/src/workers/alerts.js Outdated Show resolved Hide resolved
apps/supernova/src/workers/silences.js Outdated Show resolved Hide resolved
apps/supernova/src/components/silences/SilencesList.jsx Outdated Show resolved Hide resolved
@TilmanHaupt TilmanHaupt requested a review from ArtieReus December 5, 2024 14:27
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM fix some issues

Copy link
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Really good job. You improved the code!! Tests in the preview looks good to me. Thank you

@TilmanHaupt TilmanHaupt merged commit 454764a into main Dec 6, 2024
15 checks passed
@TilmanHaupt TilmanHaupt deleted the til-reactQuery branch December 6, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
supernova All tasks related to supernova
Projects
None yet
4 participants