-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ui): migrate ContentAreaToolbar component to Typescript and improve ContentContainer and ContentHeading #641
Conversation
🦋 Changeset detectedLatest commit: 2306c1a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
reviewing.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/ui-components/src/components/ContentHeading/ContentHeading.stories.tsx
Show resolved
Hide resolved
Thank You for the review, @taymoor89. Please re-approve, @andypf. |
Summary
ContentAreaToolbar
to TypeScript, enhancing code quality, maintainability, and scalability.ContentContainer
andContentHeading
.ContentArea
andContentAreaWrapper
to the/deprecated_js
folder (for deletion when ready) and added it to deprecated section inStorybook
.Changes Made
TypeScript Migration:
ContentAreaToolbar
component files to TypeScript.ContentAreaToolbar
,ContentArea
andContentAreaWrapper
components instead of deprecated ones.ContentArea
andContentAreaWrapper
component to/deprecated_js
so they can be deleted when ready.Testing:
ContentAreaToolbar
ContentContainer
ContentHeading
Storybook
.vitest
.Documentation:
Storybook
documentation.Release:
changeset
file.Related Issues
Testing Instructions
Storybook
Checklist