Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): proposal loading mechanism #639

Merged
merged 21 commits into from
Dec 4, 2024

Conversation

ArtieReus
Copy link
Collaborator

Summary

The goal of this proposal is to consolidate all information regarding the extension loading mechanism into a single, comprehensive document. It aims to clearly outline all discussed options with when possible with a decision, eliminating any potential misunderstandings, and to establish consensus on the approach that best fits the project’s needs.

Changes Made

  • Reviewed documentation in Epics, Emails and PFDs
  • Added new concept of Kubernets as CDN

Related Issues

@ArtieReus ArtieReus requested a review from a team as a code owner November 26, 2024 15:03
Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: ee42d3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ArtieReus ArtieReus self-assigned this Nov 26, 2024
@ArtieReus ArtieReus added documentation Improvements or additions to documentation greenhouse Greenhouse core related task labels Nov 26, 2024
andypf
andypf previously approved these changes Nov 27, 2024
Copy link
Collaborator

@andypf andypf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@taymoor89
Copy link
Contributor

taymoor89 commented Nov 27, 2024

Thanks @ArtieReus for preparing this document. 👍

Despite having concerns, IMO we might not need to take this architectural decision right now because whether we do it in one way or the other it barely affects the overall functionality of the host or extension applications. And this loading mechanism can be changed later in a less intrusive manner when we'll have more more information/requirements.

hodanoori
hodanoori previously approved these changes Nov 28, 2024
Copy link
Contributor

@hodanoori hodanoori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helped me to be informed about the new generation of our shell app, so thank you 👍

@ArtieReus ArtieReus dismissed stale reviews from hodanoori and andypf via 5119b7f November 29, 2024 08:14
Copy link
Contributor

@hodanoori hodanoori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ArtieReus ArtieReus requested a review from andypf November 29, 2024 14:11
Copy link
Contributor

@guoda-puidokaite guoda-puidokaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You for the call! I'm informed. 🙏🙈🤪

@ArtieReus ArtieReus merged commit b007ad2 into main Dec 4, 2024
13 checks passed
@ArtieReus ArtieReus deleted the artie-proposal-loading-mechanism branch December 4, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation greenhouse Greenhouse core related task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants