Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(utils): decomission mock server from juno apps #629

Merged
merged 7 commits into from
Nov 25, 2024

Conversation

barsukov
Copy link
Contributor

@barsukov barsukov commented Nov 21, 2024

Summary

Part of decomision utils is to make dependency on app obsolete, after we move all other deps we can delete this library.

Changes Made

  • fetchDb and fetchProxy will be removed as deps from all apps
  • all logic will be deleted from useMock sections

Related Issues

Screenshots (if applicable)

Testing Instructions

  1. npm i
  2. npm run TASK
  3. turbo dev or turbo test in apps like doop, example and greenhoust

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@barsukov barsukov added greenhouse Greenhouse core related task doop Doop related issues app Any app that is not specific label that lives under apps/ labels Nov 21, 2024
@barsukov barsukov added this to the Standardize build system milestone Nov 21, 2024
@barsukov barsukov self-assigned this Nov 21, 2024
Copy link

changeset-bot bot commented Nov 21, 2024

🦋 Changeset detected

Latest commit: c1a689f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cloudoperators/juno-app-greenhouse Patch
@cloudoperators/juno-app-example Patch
@cloudoperators/juno-app-doop Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 21, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-25 10:28 UTC

@barsukov barsukov changed the title chore(utils): decomission mock server from juno-utils chore(utils): decomission mock server from juno apps Nov 21, 2024
@barsukov barsukov marked this pull request as ready for review November 21, 2024 10:39
@barsukov barsukov requested a review from a team as a code owner November 21, 2024 10:39
Copy link
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove the mock integretion in doop, do we want also to remove th db.json??
https://github.com/cloudoperators/juno/blob/wowa-decomision-mock-server/apps/doop/src/db.json

Copy link
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barsukov
Copy link
Contributor Author

As I mentioned yesterday we could not remove the db.json cause they use inside of the tests files, so we would do that only when carbon is finished.

Copy link
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@andypf andypf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@barsukov barsukov merged commit b1503ed into main Nov 25, 2024
15 checks passed
@barsukov barsukov deleted the wowa-decomision-mock-server branch November 25, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Any app that is not specific label that lives under apps/ doop Doop related issues greenhouse Greenhouse core related task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants