-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(utils): decomission mock server from juno apps #629
Conversation
🦋 Changeset detectedLatest commit: c1a689f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we remove the mock integretion in doop
, do we want also to remove th db.json??
https://github.com/cloudoperators/juno/blob/wowa-decomision-mock-server/apps/doop/src/db.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same with teams
area within greenhouse?
https://github.com/cloudoperators/juno/blob/wowa-decomision-mock-server/apps/greenhouse/src/components/core-apps/org-admin/components/teams/db.json
As I mentioned yesterday we could not remove the db.json cause they use inside of the tests files, so we would do that only when carbon is finished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. For the leftover I have created new tasks:
- [Task](doop): Refactor db.json usage in tests and explore alternatives for mock data management #633
- [Task](greenhouse): Refactor db.json usage in teams tests and explore alternatives for mock data management #634
Thank you very much!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Summary
Part of decomision utils is to make dependency on app obsolete, after we move all other deps we can delete this library.
Changes Made
Related Issues
Screenshots (if applicable)
Testing Instructions
npm i
npm run TASK
Checklist