chore(ci): notify via slack when a publishing workflow fails #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fixes #409 |
3 tasks
|
fixes #409 |
hodanoori
previously approved these changes
Oct 22, 2024
hodanoori
reviewed
Oct 22, 2024
hodanoori
reviewed
Oct 22, 2024
hodanoori
reviewed
Oct 22, 2024
barsukov
requested changes
Oct 22, 2024
barsukov
approved these changes
Oct 22, 2024
andypf
approved these changes
Oct 23, 2024
andypf
added a commit
that referenced
this pull request
Oct 23, 2024
* chore(ci): uses shared notification if workflow job fails * chore(ci): adds pr for testing * chore(ci): changes to fully qualified url * chore(ci): makes use of the shared workflow correctly * chore(ci): passes webhook as input * chore(ci): reads webhook from input * chore(ci): passes the webhook as secret * chore(ci): adds mapping * chore(ci): sets secrets not within with statement * chore(ci): adds valid json * chore(ci): formats the body * chore(ci): formats the title * chore(ci): removes double JUNO on title * chore(ci): sets body rich per var * chore(ci): sets inline envs * chore(ci): sets playload in a new step * chore(ci): corrects envs json syntax * chore(ci): ensures the JSON output is compact and valid * chore(ci): adds tests with rich body * chore(ci): cleans up the call * chore(ci): adds branch to the shared task * chore(ci): removes test * chore(ci): tests reuse action in release * chore(ci): removes double quotes * chore(ci): adds test * chore(ci): adds test integration * chore(ci): adds last test * chore(ci): removes tests and setups release * chore(ci): fixes copy paste errors --------- Co-authored-by: Andreas Pfau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To ensure we're notified of any publishing failures, integrate Slack into the workflows so that a notification is posted whenever the workflow fails. This is crucial because workflows that react to a push on the main branch run after the PR is merged. At that point, there is no active control by the developer, and if the developer isn't self-checking the action logs, any issues that arise could go unnoticed. With Slack notifications, we can proactively alert the team of any failures, ensuring that problems are addressed immediately.
Changes Made
Related Issues
Screenshots (if applicable)
Testing Instructions
npm inpm run TASKChecklist