Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui): migrate Stack component to TypeScript #467

Merged
merged 1 commit into from
Sep 27, 2024
Merged

chore(ui): migrate Stack component to TypeScript #467

merged 1 commit into from
Sep 27, 2024

Conversation

gjaskiewicz
Copy link
Contributor

Summary

Migrate Stack component to TypeScript

Changes Made

  • migrate Stack component to TypeScript

Related Issues

Testing Instructions

  1. npm i
  2. turbo test

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@gjaskiewicz gjaskiewicz requested review from franzheidl and a team as code owners September 26, 2024 22:32
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2024

🦋 Changeset detected

Latest commit: b7e626d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-ui-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-27 10:17 UTC

@barsukov barsukov added the ui-components All tasks related to juno-ui-components library label Sep 27, 2024
andypf
andypf approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@andypf andypf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@barsukov barsukov merged commit 73f55e0 into main Sep 27, 2024
15 checks passed
@barsukov barsukov deleted the refactor/gjaskiewicz-stack-ts branch September 27, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andypf andypf andypf approved these changes

@barsukov barsukov barsukov approved these changes

@edda edda edda approved these changes

@franzheidl franzheidl Awaiting requested review from franzheidl franzheidl is a code owner

Assignees

@gjaskiewicz gjaskiewicz

Labels
ui-components All tasks related to juno-ui-components library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gjaskiewicz @edda @barsukov @andypf