Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): migrate AppShell and navigation components to TypeScript #360

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

gjaskiewicz
Copy link
Contributor

Summary

migrate AppShell and navigation components to TypeScript

Changes Made

  • migrate AppShell component to TypeScript
  • migrate Navigation (Top-, Side-, Tab-) components to TypeScript
  • disable faulty tests in Navigation components

Related Issues

Testing Instructions

  1. npm i
  2. turbo test

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@gjaskiewicz gjaskiewicz requested review from franzheidl and a team as code owners September 16, 2024 09:08
Copy link

changeset-bot bot commented Sep 16, 2024

🦋 Changeset detected

Latest commit: 3531347

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-ui-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 16, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-16 09:54 UTC

Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barsukov barsukov enabled auto-merge (squash) September 16, 2024 09:52
@barsukov barsukov merged commit 4ad82f4 into main Sep 16, 2024
14 checks passed
@barsukov barsukov deleted the refactor/gjaskiewicz-ts-appshell branch September 16, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants