feat(ui): pageheader custom logo #358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update styles to target universal child of container
🦋 Changeset detectedLatest commit: 0d29563 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
franzheidl
changed the title
franzheidl
changed the title
barsukov
requested changes
Sep 16, 2024
There was a problem hiding this comment.
I would suggest to close this PR for now cause @gjaskiewicz works on transition this component to Typescript in current sprint, to avoid future conflicts, if it is urgent then maybe we could add this changes to his PR. The task is #212
|
This PR is as good as done and afaik the move to TypeScript for this component hasn't begun yet. We shouldn't wait with merging this for too long as not having this feature prevents us from updating ui-components in some apps (because we changed the default logo). Therefore let's go ahead with this. |
…one (#349) * feat(docs): add Juno logos and update README to display the github one * chore(ci): add missing context for title check
* chore(heureka): fix linting issues * feat(heureka): uses TopNavigationItem instead of TabNavigationItem * Create hot-dolphins-know.md * Revert "chore(heureka): fix linting issues" This reverts commit b4ecc09. * feat(heureka): renames all tab names into navEntry * Create little-onions-obey.md * Delete .changeset/hot-dolphins-know.md
…splays a description (#339) Co-authored-by: hodanoori <[email protected]>
* chore(greenhouse): adds greenhouse dashboard and apps * chore(greenhouse): adds greenhouse to allowed scopes * chore(greenhouse): adjust build scripts * chore(greenhouse): fixes lint issues in cluster-admin * chore(greenhouse): add ts-luxon pkg to cluster-admin * chore(greenhouse): merge main branch * chore(greenhouse): extend esbuild config to build apps * chore(greenhouse): add missing entries in package.json and changeset * chore(ci): add nginx.conf to license ignore path * chore(ci): update package-lock.json * fix(build): fixes tests * chore(example): remove console logs * fix(greenhouse): add dependent apps to turbo for build * chore(greenhouse): make packages private in apps
…g filters on login (#354) * fix(supernova): fixes active filters loading order * fix(supernova): exports useGlobalsIsURLRead on the right file * fix(supernova): fixes typo and double check empty var * fix(supernova): fix typo in naming in methods * chore(core): migrate greenhouse dashboard (#337) * chore(greenhouse): adds greenhouse dashboard and apps * chore(greenhouse): adds greenhouse to allowed scopes * chore(greenhouse): adjust build scripts * chore(greenhouse): fixes lint issues in cluster-admin * chore(greenhouse): add ts-luxon pkg to cluster-admin * chore(greenhouse): merge main branch * chore(greenhouse): extend esbuild config to build apps * chore(greenhouse): add missing entries in package.json and changeset * chore(ci): add nginx.conf to license ignore path * chore(ci): update package-lock.json * fix(build): fixes tests * chore(example): remove console logs * fix(greenhouse): add dependent apps to turbo for build * chore(greenhouse): make packages private in apps * chore(supernova): add missinge dependecies in useCommunication * chore(supernova): create a new patch changeset --------- Co-authored-by: Andreas Pfau <[email protected]>
* chore(greenhouse): add version to package.json files * chore(ci): add greenhouse to scopes for title check
…the overview section (#351)
…ets (#342) chore(version): update versions with Changesets Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
6 tasks
|
Close cause of this one: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(ui): Pageheader custom logo
Allow users to pass a custom logo component to the PageHeader and render it.
Changes Made
logoprop that accepts a component to render in a slottrueorundefinedfalseornullRelated Issues
Screenshots (if applicable)
Testing Instructions
npm inpm run test/npm run test PageHeaderChecklist