Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Andypf communicator preparation #113

Merged
merged 4 commits into from
Jul 15, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/example/esbuild.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ const build = async () => {

let { host, port } = await ctx.serve({
host: "0.0.0.0",
port: parseInt(process.env.APP_PORT || process.env.PORT || 3000),
port: parseInt(process.env.APP_PORT || process.env.PORT || 3020),
barsukov marked this conversation as resolved.
Show resolved Hide resolved
servedir: "public",
})
console.log("serve on", `${host}:${port}`)
Expand Down
1 change: 1 addition & 0 deletions apps/example/src/App.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

import React, { useEffect } from "react"
import styles from "./styles.scss"

andypf marked this conversation as resolved.
Show resolved Hide resolved
import {
AppShellProvider,
AppShell,
Expand Down
5 changes: 2 additions & 3 deletions apps/template/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,14 @@
"prop-types": "^15.8.1",
"react": "18.2.0",
"react-dom": "18.2.0",
"react-test-renderer": "18.2.0",
"react-error-boundary": "^4.0.12",
"react-test-renderer": "18.2.0",
"sass": "^1.60.0",
"shadow-dom-testing-library": "^1.7.1",
"tailwindcss": "^3.3.1",
"url-state-provider": "https://assets.juno.global.cloud.sap/libs/[email protected]/package.tgz",
"util": "^0.12.4",
"zustand": "4.5.2",
"esbuild": "^0.19.5"
"zustand": "4.5.2"
},
"scripts": {
"test": "jest",
Expand Down
55 changes: 1 addition & 54 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions packages/communicator/.npmignore

This file was deleted.

4 changes: 3 additions & 1 deletion packages/communicator/esbuild.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ esbuild
ctx
.serve({
host: "0.0.0.0",
port: parseInt(process.env.APP_PORT),
port: parseInt(
process.env.COMMUNICATOR_PORT || process.env.APP_PORT || 3000
),
servedir: DEV_FOLDER,
})
.then(({ host, port }) => console.log("serve on", `${host}:${port}`))
Expand Down
Loading