chore(ci): do not use relative asset paths in prod builds (#613)

* chore(ci): do not check markdowns in ci * chore(ci): do not check markdown in ci * chore(ci): do not use relative paths in apps * chore(ci): do not use relative paths in apps
cloudoperators · Nov 15, 2024 · e71bd51 · e71bd51
1 parent 1ee3698
commit e71bd51
Show file tree

Hide file tree

Showing 8 changed files with 6 additions and 12 deletions.
diff --git a/.github/scripts/build-vite-app.sh b/.github/scripts/build-vite-app.sh
@@ -7,13 +7,13 @@ build_folder=$(dirname $entry_file)
 package_name=$(jq -r '.name' $PACKAGE_PATH/package.json)
 
 # Run build using turbo
-npx turbo run build:static --filter $package_name
+npx turbo run build:static --filter $package_name -- --base ./
 
 # Copy build folder to deploy path
 mkdir -p "$DEPLOY_PATH/$TARGET_FOLDER"
 cp -r "$PACKAGE_PATH/$build_folder/." "$DEPLOY_PATH/$TARGET_FOLDER"
 
 # Generate appProps.json if APP_PROPS_BASE64 is non-empty
 if [ -n "$APP_PROPS_BASE64" ]; then
-  echo "$APP_PROPS_BASE64" | base64 -d > "$DEPLOY_PATH/$TARGET_FOLDER/appProps.json"
+  echo "$APP_PROPS_BASE64" | base64 -d >"$DEPLOY_PATH/$TARGET_FOLDER/appProps.json"
 fi
diff --git a/apps/carbon/vite.config.ts b/apps/carbon/vite.config.ts
@@ -37,7 +37,6 @@ export default defineConfig(({ mode }) => {
   if (mode === "static") {
     return {
       ...sharedConfig,
-      base: "./", // Relative Path in Generated index.html
       build: {
         outDir: "build",
       },

diff --git a/apps/doop/vite.config.ts b/apps/doop/vite.config.ts
@@ -30,7 +30,6 @@ export default defineConfig(({ mode }) => {
   if (mode === "static") {
     return {
       ...sharedConfig,
-      base: "./", // Relative Path in Generated index.html
       build: {
         outDir: "build",
       },

diff --git a/apps/example/vite.config.ts b/apps/example/vite.config.ts
@@ -30,7 +30,6 @@ export default defineConfig(({ mode }) => {
   if (mode === "static") {
     return {
       ...sharedConfig,
-      base: "./", // Relative Path in Generated index.html
       build: {
         outDir: "build",
       },

diff --git a/apps/greenhouse/vite.config.ts b/apps/greenhouse/vite.config.ts
@@ -31,7 +31,6 @@ export default defineConfig(({ mode }) => {
   if (mode === "static") {
     return {
       ...sharedConfig,
-      base: "./", // Relative Path in Generated index.html
       build: {
         outDir: "build",
       },

diff --git a/apps/heureka/vite.config.ts b/apps/heureka/vite.config.ts
@@ -30,7 +30,6 @@ export default defineConfig(({ mode }) => {
   if (mode === "static") {
     return {
       ...sharedConfig,
-      base: "./", // Relative Path in Generated index.html
       build: {
         outDir: "build",
       },

diff --git a/apps/supernova/vite.config.ts b/apps/supernova/vite.config.ts
@@ -30,7 +30,6 @@ export default defineConfig(({ mode }) => {
   if (mode === "static") {
     return {
       ...sharedConfig,
-      base: "./", // Relative Path in Generated index.html
       build: {
         outDir: "build",
       },

diff --git a/package-lock.json b/package-lock.json