feat(authN) - Add udpated_by for delete operations #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkrzyz
force-pushed
the
mikrzyz/issue-358
branch
3 times, most recently
from
a544358 to
98e0706
Compare
michalkrzyz
force-pushed
the
mikrzyz/issue-358
branch
2 times, most recently
from
cfb4e85 to
554ae9e
Compare
michalkrzyz
force-pushed
the
mikrzyz/issue-358
branch
2 times, most recently
from
1f5b22b to
e4c14f7
Compare
michalkrzyz
requested review from
drochow,
MR2011 and
dorneanu
as code owners
michalkrzyz
commented
Dec 11, 2024
| type StateFilterType int | ||
|
|
||
| const ( | ||
| Active StateFilterType = 0 |
There was a problem hiding this comment.
@reviewers - wouldn't it be better to use string value instead of int for that? Please help me with your opinion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add updated_by update for delete operation. This way deleted item can be checked for user who deleted an item (under circumstances that the item was not changed/updated after deletion).
Add possibility to filter through deleted items, active and all (deleted and active). Default is active.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist