Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(comp.backend): Implement Wild Card Search for Component Instance #357

Merged
merged 2 commits into from
Nov 7, 2024
Merged

feat(comp.backend): Implement Wild Card Search for Component Instance #357

merged 2 commits into from
Nov 7, 2024

Conversation

dustindemmerle
Copy link
Collaborator

Description

Added wild card search for component instances

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

added DB test to component_instance_test.go

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@dustindemmerle dustindemmerle marked this pull request as ready for review November 7, 2024 13:21
@MR2011 MR2011 merged commit 4e915ba into main Nov 7, 2024
7 checks passed
@MR2011 MR2011 deleted the dustindemmerle/issue-232/component_instance_search branch November 7, 2024 13:30
dustindemmerle added a commit that referenced this pull request Nov 25, 2024
@dustindemmerle
feat(comp.backend): Implement Wild Card Search for Component Instance (…
352cdc6 
…#357)

* added Component Instance Search + DB Test

* go.mod changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MR2011 MR2011 MR2011 approved these changes

@drochow drochow Awaiting requested review from drochow drochow is a code owner

@dorneanu dorneanu Awaiting requested review from dorneanu dorneanu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(comp.backend): Implement Wild Card Search for Component Instance
2 participants
@dustindemmerle @MR2011