ADR - Handling component version in policy violation based scanners #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drochow
requested changes
Oct 18, 2024
|
@maxwellL21 please address |
|
@drochow Hey David, Sorry for the wait. I added the mermaid diagrams. Should we keep the "images" folder? To include the original diagrams? Also would you like the Mermaid diagrams to have the 1 to many relationships, etc? Or is that detail not necessary |
…compliance-scanning-adr
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
…compliance-scanning-adr
…compliance-scanning-adr
…compliance-scanning-adr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the ADR for handling "component" entities in Heureka for policy scanning and adds an "images" folder for the ADR documentations. The description of the ADR deals with the following issue: The current Entity Relationships in Heureka are defined for vulnerabilities in objects like containers, where it is intuitive to have ComponentVersion and ComponentInstances. For non-compliance (not exactly vulnerabilities) in entities like Security Group, how to adapt to existing data model?
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist