Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pluginbundle proposal #99

Merged
merged 16 commits into from
Apr 29, 2024
Merged

pluginbundle proposal #99

merged 16 commits into from
Apr 29, 2024

Conversation

auhlig
Copy link
Member

@auhlig auhlig commented Apr 5, 2024 •
edited
Loading

as discussion and 1st very pragmatic approach for #83. @IvoGoman

this PR adds a PluginBundle CRD (naming?) to have organization and cluster admins define a set of plugins to be run on all onboarded clusters.

@github-actions github-actions bot added documentation Improvements or additions to documentation feature core-apis helm-charts labels Apr 5, 2024
@IvoGoman IvoGoman force-pushed the feat/pluginbundle branch from 00d11b4 to 9a5fad4 Compare April 15, 2024 11:39
@IvoGoman IvoGoman self-assigned this Apr 18, 2024
@IvoGoman IvoGoman force-pushed the feat/pluginbundle branch from 9a5fad4 to 0884fc6 Compare April 22, 2024 17:17
@IvoGoman IvoGoman force-pushed the feat/pluginbundle branch from 0884fc6 to 3b6fac9 Compare April 22, 2024 17:25
@IvoGoman IvoGoman self-requested a review April 22, 2024 17:28
@IvoGoman IvoGoman force-pushed the feat/pluginbundle branch from 8414389 to c467211 Compare April 23, 2024 12:54
@IvoGoman IvoGoman marked this pull request as ready for review April 23, 2024 12:55
@github-actions GitHub Actions
Copy link

⚠️ Chart oci://ghcr.io/cloudoperators/greenhouse/charts/manager:0.1.1 already exists in OCI registry. Please increment the chart version.

1 similar comment
@github-actions GitHub Actions
Copy link

⚠️ Chart oci://ghcr.io/cloudoperators/greenhouse/charts/manager:0.1.1 already exists in OCI registry. Please increment the chart version.

@github-actions GitHub Actions
Copy link

⚠️ Chart oci://ghcr.io/cloudoperators/greenhouse/charts/manager:0.1.1 already exists in OCI registry. Please increment the chart version.

@IvoGoman IvoGoman force-pushed the feat/pluginbundle branch from fac16a5 to 5d10552 Compare April 25, 2024 13:59
kengou
kengou requested changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@kengou kengou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helm-lint action failed. Can you please take care of it ?

@IvoGoman IvoGoman force-pushed the feat/pluginbundle branch from 5d10552 to 04af5f9 Compare April 26, 2024 14:26
@github-actions GitHub Actions
Copy link

⚠️ Chart oci://ghcr.io/cloudoperators/greenhouse/charts/greenhouse:0.1.4 already exists in OCI registry. Please increment the chart version.

@IvoGoman IvoGoman force-pushed the feat/pluginbundle branch from a05ebbc to ac22402 Compare April 26, 2024 14:38
@IvoGoman IvoGoman requested a review from kengou April 26, 2024 14:46
auhlig and others added 16 commits April 29, 2024 15:52
@auhlig @IvoGoman
proposal
23081b1
@IvoGoman
Automatic application of license header
b14f8b3
@auhlig @IvoGoman
Update pkg/apis/greenhouse/v1alpha1/pluginbundle_types.go
84b8fae
@IvoGoman
add controller tests, add logic around ownerreferences
48e2835
@IvoGoman
plugin admission returns warn if the Plugin is owned by a PluginPreset
2c395af
@IvoGoman
add create, update validation for pluginbundle
e1ea3ab
@IvoGoman
rename to pluginpreset
7958e64
@IvoGoman
validate Preset OptionValues
19dbec5
@IvoGoman
embed pluginSpec instead of individual fields
5c123cb
@IvoGoman
fix: ensure clusterName is immutable in the embedded pluginSpec
5a9d2d1
@IvoGoman
trigger reconcile if Cluster in same namespace was changed
8787db6
@IvoGoman
add enduser docs for the pluginpreset
84bba02
@IvoGoman
Skip existing plugins, add StatusConditions
5348108
@IvoGoman
sync greenhouse chart dependencies
4846266
@IvoGoman
fix: controller now watches label changes on the cluster objects
6d71344
@IvoGoman
update greenhouse umbrella chart.lock
e626974
@IvoGoman IvoGoman force-pushed the feat/pluginbundle branch from ac22402 to e626974 Compare April 29, 2024 14:15
@IvoGoman IvoGoman merged commit b71f2f1 into main Apr 29, 2024
7 checks passed
@IvoGoman IvoGoman deleted the feat/pluginbundle branch April 29, 2024 14:24
@IvoGoman IvoGoman linked an issue Apr 29, 2024 that may be closed by this pull request
[FEAT] - Plugin Bundle/ Cluster Preset Concept #83
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kengou kengou kengou approved these changes

@IvoGoman IvoGoman Awaiting requested review from IvoGoman

@onuryilmaz onuryilmaz Awaiting requested review from onuryilmaz

@uwe-mayer uwe-mayer Awaiting requested review from uwe-mayer

@andypf andypf Awaiting requested review from andypf

@ArtieReus ArtieReus Awaiting requested review from ArtieReus

@edda edda Awaiting requested review from edda

@hodanoori hodanoori Awaiting requested review from hodanoori

@TilmanHaupt TilmanHaupt Awaiting requested review from TilmanHaupt

Assignees

@IvoGoman IvoGoman

Labels
core-apis dependencies documentation Improvements or additions to documentation feature helm-charts idproxy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] - Plugin Bundle/ Cluster Preset Concept
3 participants
@auhlig @kengou @IvoGoman